Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_test_utils): add jump_clock interface #7638

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jun 24, 2024

Description

Add jump_clock interface

Tests performed

Tested with the other PR: #7637

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jun 24, 2024
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 24, 2024
@kminoda kminoda marked this pull request as ready for review June 24, 2024 03:29
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.49%. Comparing base (507e3f4) to head (006e193).
Report is 125 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7638      +/-   ##
==========================================
+ Coverage   14.84%   23.49%   +8.65%     
==========================================
  Files        1999      629    -1370     
  Lines      139163    57363   -81800     
  Branches    43716    22296   -21420     
==========================================
- Hits        20661    13480    -7181     
+ Misses      95731    41838   -53893     
+ Partials    22771     2045   -20726     
Flag Coverage Δ
differential 23.49% <100.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda marked this pull request as draft June 24, 2024 04:09
Signed-off-by: kminoda <[email protected]>
@kminoda kminoda marked this pull request as ready for review June 24, 2024 13:05
@kyoichi-sugahara
Copy link
Contributor

😍

   * Be careful when using this function, as it can affect the behavior of
   * the system under test. Consider using ament_add_ros_isolated_gtest to
   * isolate the system under test from the ROS clock.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you so much for the contributin to the package.
I really appreciate it if the package is developed by the perception and other modules developer. And also welcome to proposing the change to original implementation too.

@kminoda kminoda enabled auto-merge (squash) June 24, 2024 13:25
@kminoda kminoda changed the title feat(auoware_test_utils): add jump_clock interface feat(autoware_test_utils): add jump_clock interface Jun 24, 2024
@kminoda kminoda merged commit dcb8803 into autowarefoundation:main Jun 24, 2024
32 checks passed
@kminoda kminoda deleted the feat/autoware_test_utils/add_jump_clock branch June 24, 2024 13:41
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…n#7638)

* feat(auoware_test_utils): add jump_clock interface

Signed-off-by: kminoda <[email protected]>

* add comment

Signed-off-by: kminoda <[email protected]>

---------

Signed-off-by: kminoda <[email protected]>
Signed-off-by: Simon Eisenmann <[email protected]>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…n#7638)

* feat(auoware_test_utils): add jump_clock interface

Signed-off-by: kminoda <[email protected]>

* add comment

Signed-off-by: kminoda <[email protected]>

---------

Signed-off-by: kminoda <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* feat(auoware_test_utils): add jump_clock interface

Signed-off-by: kminoda <[email protected]>

* add comment

Signed-off-by: kminoda <[email protected]>

---------

Signed-off-by: kminoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants