Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(external_cmd_selector): prefix package and namespace with au… #7384

Merged
merged 2 commits into from
Jun 10, 2024
Merged

refactor(external_cmd_selector): prefix package and namespace with au… #7384

merged 2 commits into from
Jun 10, 2024

Conversation

yhisaki
Copy link
Contributor

@yhisaki yhisaki commented Jun 8, 2024

Description

This PR adds the autoware_ prefix to the package and puts headers in the autoware namespace.

Part of:

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 8, 2024
@yhisaki yhisaki added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 10, 2024
@yhisaki yhisaki merged commit 038a8c4 into autowarefoundation:main Jun 10, 2024
22 of 24 checks passed
@yhisaki yhisaki deleted the autoware_prefix-external_cmd_selector branch June 10, 2024 05:07
@SakodaShintaro SakodaShintaro mentioned this pull request Jun 10, 2024
Merged
4 tasks
@esteve esteve mentioned this pull request Jun 12, 2024
Open
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
@yhisaki @KhalilSelyan
refactor(external_cmd_selector): prefix package and namespace with au… (
a96a0f0 
#7384)

refactor(external_cmd_selector): prefix package and namespace with autoware_

Signed-off-by: Y.Hisaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

Assignees
No one assigned
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhisaki @takayuki5168