Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lane_departure_checker)!: prefix package and namespace with autoware #7325

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Jun 6, 2024

Description

rename package to autoware_lane_departure_checker from lane_departure_checker.

Part of:

Tests performed

run psim and confirmed lane departure check is working appropriately in start_planner
Screenshot from 2024-06-06 20-34-25

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 6, 2024
@kyoichi-sugahara kyoichi-sugahara force-pushed the prefix-lane_departure_checker branch from f2ea2da to 19a4af0 Compare June 6, 2024 12:26
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 6, 2024
@xmfcx xmfcx changed the title chore(lane_departure_checker): add prefix autoware_ to lane_departure_checker package refactor(lane_departure_checker)!: prefix package and namespace with autoware_ Jun 6, 2024
@kyoichi-sugahara kyoichi-sugahara changed the title refactor(lane_departure_checker)!: prefix package and namespace with autoware_ refactor(lane_departure_checker)!: prefix package and namespace with autoware Jun 6, 2024
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kyoichi-sugahara kyoichi-sugahara force-pushed the prefix-lane_departure_checker branch 2 times, most recently from 9934054 to d4165e5 Compare June 7, 2024 04:34
@kyoichi-sugahara kyoichi-sugahara force-pushed the prefix-lane_departure_checker branch from d873404 to d4f1f49 Compare June 7, 2024 06:23
@kyoichi-sugahara kyoichi-sugahara merged commit f03323f into autowarefoundation:main Jun 7, 2024
21 of 23 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the prefix-lane_departure_checker branch June 7, 2024 10:35
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…autoware (#7325)

* add prefix autoware_ to lane_departure_checker package

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants