-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(planning_validator)!: prefix package and namespace with autoware #7320
Merged
kyoichi-sugahara
merged 5 commits into
autowarefoundation:main
from
kyoichi-sugahara:prefix-planning_validator
Jun 7, 2024
Merged
refactor(planning_validator)!: prefix package and namespace with autoware #7320
kyoichi-sugahara
merged 5 commits into
autowarefoundation:main
from
kyoichi-sugahara:prefix-planning_validator
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyoichi-sugahara
requested review from
kosuke55,
TakaHoribe,
rej55,
mkuri,
soblin,
satoshi-ota,
shmpwk,
taikitanaka3,
takayuki5168,
TomohitoAndo,
tkimura4 and
zulfaqar-azmi-t4
as code owners
June 6, 2024 10:23
kyoichi-sugahara
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jun 6, 2024
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
labels
Jun 6, 2024
kyoichi-sugahara
force-pushed
the
prefix-planning_validator
branch
from
June 6, 2024 11:55
267ae15
to
933f55a
Compare
github-actions
bot
removed
the
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
label
Jun 6, 2024
satoshi-ota
approved these changes
Jun 6, 2024
Could you fix autoware.universe/planning/.pages Line 90 in 31c1672
|
kyoichi-sugahara
changed the title
chore(planning_validator): add prefix autoware_
refactor(planning_validator)!: prefix package and namespace with autoware
Jun 6, 2024
planning_validator
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara
force-pushed
the
prefix-planning_validator
branch
from
June 7, 2024 04:26
1763d3e
to
d6d8b07
Compare
4 tasks
TakaHoribe
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds autoware prefix in the package namespace.
kyoichi-sugahara
merged commit Jun 7, 2024
7d6c2fd
into
autowarefoundation:main
25 of 26 checks passed
This was referenced Jun 7, 2024
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…ware (#7320) * add autoware_ prefix to planning_validator Signed-off-by: kyoichi-sugahara <[email protected]> * add prefix to package name in .pages Signed-off-by: kyoichi-sugahara <[email protected]> * fix link of the image --------- Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rename package to autoware_planning_validator from planninga_validator.
Part of:
Tests performed
check psim and echo topic with following command
get the following output
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.