Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(planning_validator)!: prefix package and namespace with autoware #7320

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Jun 6, 2024

Description

rename package to autoware_planning_validator from planninga_validator.

Part of:

Tests performed

check psim and echo topic with following command

ros2 topic echo /planning/autoware_planning_validator/validation_status

get the following output

---
stamp:
  sec: 1717669025
  nanosec: 502505657
is_valid_size: true
is_valid_finite_value: true
is_valid_interval: true
is_valid_relative_angle: true
is_valid_curvature: true
is_valid_lateral_acc: true
is_valid_longitudinal_max_acc: true
is_valid_longitudinal_min_acc: true
is_valid_steering: true
is_valid_steering_rate: true
is_valid_velocity_deviation: true
is_valid_distance_deviation: true
is_valid_longitudinal_distance_deviation: true
is_valid_forward_trajectory_length: true
trajectory_size: 162
max_interval_distance: 1.0000000141980752
max_relative_angle: 0.00010982225903810594
max_curvature: 7.321483939521648e-05
max_lateral_acc: 0.0012731255761711014
max_longitudinal_acc: 0.9462579488754272
min_longitudinal_acc: -2.160729053457544e-07
max_steering: 0.00020426939907153982
max_steering_rate: 0.00028096447863051784
velocity_deviation: 0.25
distance_deviation: 0.1633100812084684
longitudinal_distance_deviation: 0.0
forward_trajectory_length_required: 0.0
forward_trajectory_length_measured: 0.0
invalid_count: 0
---

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kyoichi-sugahara kyoichi-sugahara added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 6, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 6, 2024
@kyoichi-sugahara kyoichi-sugahara force-pushed the prefix-planning_validator branch from 267ae15 to 933f55a Compare June 6, 2024 11:55
@github-actions github-actions bot removed the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jun 6, 2024
@satoshi-ota
Copy link
Contributor

Could you fix .pages as well?

- 'Planning Validator': planning/planning_validator

@kyoichi-sugahara kyoichi-sugahara changed the title chore(planning_validator): add prefix autoware_ planning_validator refactor(planning_validator)!: prefix package and namespace with autoware Jun 6, 2024
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara kyoichi-sugahara force-pushed the prefix-planning_validator branch from 1763d3e to d6d8b07 Compare June 7, 2024 04:26
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds autoware prefix in the package namespace.

@kyoichi-sugahara kyoichi-sugahara merged commit 7d6c2fd into autowarefoundation:main Jun 7, 2024
25 of 26 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the prefix-planning_validator branch June 7, 2024 07:22
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…ware (#7320)

* add autoware_ prefix to planning_validator

Signed-off-by: kyoichi-sugahara <[email protected]>

* add prefix to package name in .pages

Signed-off-by: kyoichi-sugahara <[email protected]>

* fix link of the image

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants