Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_planning_validator): revert node name change #7371

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

change node name in the PR and it causes diag error.
As a result, autoware engage from RVIZ gui was not working.
image
The error was following by clicking the gui bottom

[service_log_checker_node-4] [ERROR 1717762673.010612554] [system.service_log_checker]: /api/operation_mode/change_to_autonomous: status code 1 'The mode change is blocked by the system.' (/default_ad_api/node/operation_mode) (set_error():84)

Tests performed

confirmed engage works with psim

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 7, 2024
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 7, 2024
@kyoichi-sugahara kyoichi-sugahara merged commit f328a15 into autowarefoundation:main Jun 7, 2024
34 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the fix/change_node_name branch June 7, 2024 16:50
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
revert node name change

Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants