Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autonomous_emergency_braking): aeb for backwards driving #7279

Conversation

danielsanchezaran
Copy link
Contributor

Description

NOTE: requires #7264 (review) to be merged first

The present PR adds functionality to detect and react to rear obstacles using the AEB module and issue an emergency stop.

Related links

Tests performed

PSim

cap-.2024-06-05-17-47-28.mp4

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:system System design and integration. (auto-assigned) labels Jun 5, 2024
@danielsanchezaran danielsanchezaran force-pushed the feat/aeb-backwards-driving-no-conflicts branch from 55f12f8 to 4ce91e2 Compare June 5, 2024 08:53
@github-actions github-actions bot removed the component:system System design and integration. (auto-assigned) label Jun 5, 2024
@danielsanchezaran danielsanchezaran added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 5, 2024
@danielsanchezaran danielsanchezaran marked this pull request as ready for review June 5, 2024 08:57
@danielsanchezaran danielsanchezaran force-pushed the feat/aeb-backwards-driving-no-conflicts branch from 979bb95 to cceacaf Compare June 6, 2024 05:40
@danielsanchezaran danielsanchezaran changed the title feat(autonomous_emergency_braking): AEB for backwards driving feat(autonomous_emergency_braking): aeb for backwards driving Jun 6, 2024
@danielsanchezaran danielsanchezaran force-pushed the feat/aeb-backwards-driving-no-conflicts branch 3 times, most recently from 8efc73d to 40591d9 Compare June 12, 2024 06:07
@danielsanchezaran danielsanchezaran force-pushed the feat/aeb-backwards-driving-no-conflicts branch 2 times, most recently from f9b2a58 to 9373b9e Compare June 12, 2024 07:01
@danielsanchezaran danielsanchezaran enabled auto-merge (squash) June 12, 2024 07:02
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (e24f48d) to head (9373b9e).
Report is 129 commits behind head on main.

Current head 9373b9e differs from pull request most recent head e1227e4

Please upload reports for the commit e1227e4 to get more accurate results.

Files Patch % Lines
...autoware_autonomous_emergency_braking/src/node.cpp 0.00% 11 Missing ⚠️
...ude/autoware_autonomous_emergency_braking/node.hpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7279       +/-   ##
==========================================
- Coverage   15.10%   0.00%   -15.11%     
==========================================
  Files        1922       2     -1920     
  Lines      134796     460   -134336     
  Branches    43473       0    -43473     
==========================================
- Hits        20364       0    -20364     
+ Misses      91780     460    -91320     
+ Partials    22652       0    -22652     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielsanchezaran danielsanchezaran force-pushed the feat/aeb-backwards-driving-no-conflicts branch from 9373b9e to eea4530 Compare June 12, 2024 07:35
Signed-off-by: Daniel Sanchez <[email protected]>
Signed-off-by: Daniel Sanchez <[email protected]>
@danielsanchezaran danielsanchezaran force-pushed the feat/aeb-backwards-driving-no-conflicts branch from eea4530 to e1227e4 Compare June 12, 2024 08:05
@danielsanchezaran danielsanchezaran merged commit 763c112 into autowarefoundation:main Jun 12, 2024
23 of 24 checks passed
@danielsanchezaran danielsanchezaran deleted the feat/aeb-backwards-driving-no-conflicts branch June 12, 2024 08:27
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* add support for backward path AEB

Signed-off-by: Daniel Sanchez <[email protected]>

* fix sign)

Signed-off-by: Daniel Sanchez <[email protected]>

* add abs and protect against nan

Signed-off-by: Daniel Sanchez <[email protected]>

* solve sign problem with relative speed

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants