Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(object_recognition_utils): fix failing test #7268

Merged

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Jun 5, 2024

Description

This fixes the failing test for object_recognition_utils caused by migration to autoware_msgs.
New autoware_msgs does not have the bound limit for predicted path so there are tests that are no longer needed.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jun 5, 2024
@mitsudome-r mitsudome-r added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 5, 2024
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukkysaito yukkysaito merged commit 97173bc into autowarefoundation:main Jun 5, 2024
12 of 13 checks passed
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…7268)

* feat(object_recognition_utils): fix failing test

Signed-off-by: Ryohsuke Mitsudome <[email protected]>

* Update common/object_recognition_utils/test/src/test_predicted_path_utils.cpp

---------

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Yukihiro Saito <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* feat(object_recognition_utils): fix failing test

Signed-off-by: Ryohsuke Mitsudome <[email protected]>

* Update common/object_recognition_utils/test/src/test_predicted_path_utils.cpp

---------

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Yukihiro Saito <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants