feat(external_cmd_converter): replace polling takeData function with the callback function #7263
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Jun 10, 2024 in 40s
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method node.cpp: ExternalCmdConverterNode::on_external_cmd
- Complex Conditional node.cpp: ExternalCmdConverterNode::on_external_cmd
✅ Improving Code Health:
- Bumpy Road Ahead node.cpp: ExternalCmdConverterNode::checkRemoteTopicRate
Annotations
Check warning on line 143 in vehicle/external_cmd_converter/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
ExternalCmdConverterNode::on_external_cmd has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 105 in vehicle/external_cmd_converter/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Conditional
ExternalCmdConverterNode::on_external_cmd has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check notice on line 215 in vehicle/external_cmd_converter/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Bumpy Road Ahead
ExternalCmdConverterNode::checkRemoteTopicRate is no longer above the threshold for logical blocks with deeply nested code
Loading