feat(external_cmd_converter): replace polling takeData function with the callback function #7263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h takeData function. Signed-off-by: N-Eiki <[email protected]>
Signed-off-by: N-Eiki <[email protected]>
Signed-off-by: N-Eiki <[email protected]>
github-actions
bot
added
the
component:vehicle
|
@N-Eiki |
shmpwk
reviewed
Jun 5, 2024
vehicle/external_cmd_converter/include/external_cmd_converter/node.hpp
Outdated
Show resolved
Hide resolved
vehicle/external_cmd_converter/include/external_cmd_converter/node.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: N-Eiki <[email protected]>
… to snake_case, delete redundant if sentences Signed-off-by: N-Eiki <[email protected]>
Signed-off-by: N-Eiki <[email protected]>
Signed-off-by: N-Eiki <[email protected]>
Signed-off-by: N-Eiki <[email protected]>
…com:N-Eiki/autoware.universe into feat/use_takeData_in_external_cmd_converter
|
cppcheck-all / cppcheck-all (pull_request) is just for monitoring, so this failure is no problem. |
shmpwk
reviewed
Jun 6, 2024
shmpwk
added
the
tag:run-build-and-test-differential
shmpwk
reviewed
Jun 9, 2024
vehicle/external_cmd_converter/include/external_cmd_converter/node.hpp
Outdated
Show resolved
Hide resolved
shmpwk
requested changes
Jun 9, 2024
Signed-off-by: N-Eiki <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…the callback function (#7263) * delete duplicated sentence. \n replace callback data get function with takeData function. Signed-off-by: N-Eiki <[email protected]> * add maintainer Signed-off-by: N-Eiki <[email protected]> * delete name Signed-off-by: N-Eiki <[email protected]> * style(pre-commit): autofix * style(pre-commit): autofix * handle to comment: delete waste line Signed-off-by: N-Eiki <[email protected]> * fix: treat clang-tidy-differential's warnings. for examples CamelCase to snake_case, delete redundant if sentences Signed-off-by: N-Eiki <[email protected]> * fix mailadress miss Signed-off-by: N-Eiki <[email protected]> * style(pre-commit): autofix * format by clang-format Signed-off-by: N-Eiki <[email protected]> * delete static Signed-off-by: N-Eiki <[email protected]> * unify to *_sub_ Signed-off-by: N-Eiki <[email protected]> --------- Signed-off-by: N-Eiki <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, instead of getting msg in callback, it is changed to get msg using takeData function of polling_subscriber in utils.
Related links
Tests performed
the module works as before
before
before.mp4
after
after.mp4
Notes for reviewers
Interface changes
none
ROS Topic Changes
ROS Parameter Changes
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.