refactor(lidar_centerpoint): rework parameters #7204
Conversation
github-actions
bot
added
type:documentation
|
@tby-udel Thank you for your contribution. |
tby-udel
changed the title
There was a problem hiding this comment.
@tby-udel
Thank you for your contribution.
As it is now, the package does not comply fully with the schema.
For example, in addition to the changes to the README.md (the old tables should be deleted), some schemas are missing - some parameters are not covered (see the yaml files).
Could you address this points in the PR 🙏 ?
…l/autoware.universe into lidar_centerpoint_branch updated readme and schema files.
|
@tby-udel |
…l/autoware.universe into lidar_centerpoint_branch update the branch first, then renamed one .schema.json file.
|
It's solved now and updated.
…On Wed, Jun 5, 2024 at 3:41 AM Kenzo Lobos Tsunekawa < ***@***.***> wrote:
@tby-udel <https://github.com/tby-udel>
Thanks for handling the changes. However, it seems that one of the schema
files does not have the schema.json file extension and that the CI/CD is
failing for the schemas. Could you take a look at it ? 🙏
—
Reply to this email directly, view it on GitHub
<#7204 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCL5CFSVNPRAMBOEB7XZSZTZF26I5AVCNFSM6AAAAABITPUZ26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBZGA4TSMZQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Sincerely,
Boyang Tian
Phd Student, University of Delaware
3026099121 | ***@***.***
[image: linkedin] <https://www.linkedin.com/in/boyangtian>
|
|
@tby-udel |
|
Closing in favor of #7421 |
Description
Implement the ROS Node configuration layout for the lidar_centerpoint package.
Remove the default value from the source code in order to ensure all parameter values are passed from the parameter files.
Use types that match the ones returned from declare_parameter() in order to prevent confusion and potential coding errors.
Move the default parameter file to a standardized location. Use the JSON Schema for that.
Tests performed
Built and launched
Notes for reviewers
I was using autoware's docker with Nvidia to build and do the test, and pulled the docker tagged: ghcr.io/autowarefoundation/autoware-universe:latest-cuda. However, after I successfully made changes, built and launched the docker's lidar_centerpoint code, I found that the code is very different from the current autoware.universe repository, so I re-changed the code in the current autoware.universe and built and tested.
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
☑ I've confirmed the contribution guidelines.
☑ The PR follows the pull request guidelines.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
There are no open discussions or they are tracked via tickets.
The PR is ready for merge.
After all checkboxes are checked, anyone who has write access can merge the PR.