-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(obstacle_cruise_planner): rework parameters #7372
base: main
Are you sure you want to change the base?
Conversation
@Ariiees Thanks for the PR. However, the PR seems to be failing in the CI for DCO check. When you push commits, could you push with signed-off commits? For example by running the following command: There seems to be a conflict with the latest main as well so you might have to resolve them while you do the rebase as well. |
Could you also resolve the conflicts? |
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Hi @mitsudome-r , |
planning/autoware_obstacle_cruise_planner/test/test_obstacle_cruise_planner_node_interface.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Ariiees <[email protected]>
29bac65
to
4972722
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7372 +/- ##
==========================================
- Coverage 23.91% 23.90% -0.01%
==========================================
Files 1381 1382 +1
Lines 101939 101961 +22
Branches 38822 38825 +3
==========================================
+ Hits 24376 24378 +2
- Misses 75119 75139 +20
Partials 2444 2444
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ariiees <[email protected]>
Signed-off-by: Ariiees <[email protected]>
Description
Implement the ROS Node configuration layout for the obstacle_cruise_planner package.
Test performed
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to autoware_obstacle_cruise_planner
ros2 launch autoware_obstacle_cruise_planner obstacle_cruise_planner.launch.xml
Interface Changes
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.