Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(obstacle_cruise_planner): rework parameters #7372

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

Ariiees
Copy link
Contributor

@Ariiees Ariiees commented Jun 7, 2024

Description

Implement the ROS Node configuration layout for the obstacle_cruise_planner package.

Test performed

  1. Build colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to autoware_obstacle_cruise_planner
  2. Launch ros2 launch autoware_obstacle_cruise_planner obstacle_cruise_planner.launch.xml

Interface Changes

  1. Update obstacle_cruise_planner.param.yaml to solve the original bug.
  2. Create schema: obstacle_cruise_planner.schema.json
  3. Update README.md

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.
    After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jun 7, 2024
@mitsudome-r
Copy link
Member

@Ariiees Thanks for the PR.

However, the PR seems to be failing in the CI for DCO check. When you push commits, could you push with signed-off commits?

For example by running the following command:
git rebase -i --signoff origin/main

There seems to be a conflict with the latest main as well so you might have to resolve them while you do the rebase as well.

@mitsudome-r
Copy link
Member

Could you also resolve the conflicts?

Copy link

github-actions bot commented Jul 11, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@Ariiees
Copy link
Contributor Author

Ariiees commented Jul 11, 2024

Could you also resolve the conflicts?

Hi @mitsudome-r ,
Thank you for your time! I have resolved the conflicts and rebased the branch. Could you please check it again? Thanks!

@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 1, 2024
@Ariiees Ariiees force-pushed the obstacle_cruise_planner branch from 29bac65 to 4972722 Compare August 9, 2024 07:28
@mitsudome-r mitsudome-r added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.90%. Comparing base (7424c48) to head (c25db8b).
Report is 219 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7372      +/-   ##
==========================================
- Coverage   23.91%   23.90%   -0.01%     
==========================================
  Files        1381     1382       +1     
  Lines      101939   101961      +22     
  Branches    38822    38825       +3     
==========================================
+ Hits        24376    24378       +2     
- Misses      75119    75139      +20     
  Partials     2444     2444              
Flag Coverage Δ *Carryforward flag
differential 13.75% <ø> (?)
total 23.91% <ø> (ø) Carriedforward from 7424c48

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ariiees Ariiees requested a review from brkay54 as a code owner October 24, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants