feat(pointcloud_preprocessor): calculate visibility score in ring outlier filter #7011
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
May 16, 2024 in 43s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method ring_outlier_filter_nodelet.cpp: RingOutlierFilterComponent::calculateVisibilityScore
- Complex Method ring_outlier_filter_nodelet.cpp: RingOutlierFilterComponent::paramCallback
- Bumpy Road Ahead ring_outlier_filter_nodelet.cpp: RingOutlierFilterComponent::calculateVisibilityScore
✅ Improving Code Health:
- Complex Method ring_outlier_filter_nodelet.cpp: RingOutlierFilterComponent::faster_filter
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
RingOutlierFilterComponent::faster_filter decreases in cyclomatic complexity from 29 to 28, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
RingOutlierFilterComponent::calculateVisibilityScore has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
RingOutlierFilterComponent::paramCallback has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
RingOutlierFilterComponent::calculateVisibilityScore has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Loading