Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pointcloud_preprocessor): calculate visibility score in ring outlier filter #7011

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented May 14, 2024

Description

calculate visibility score based on oulier pointcloud.
This feature is disabled by default with publish_outlier_pointcloud

Tests performed

  1. launch logging_simulator with following commnad
ros2 launch autoware_launch logging_simulator.launch.xml map_path:=/path_to_your_map vehicle_model:=lexus sensor_model:=aip_xx1 sensing:=true
  1. Enabling this feature (for left lidar for example) with following command
ros2 param set /sensing/lidar/top/ring_outlier_filter publish_excluded_points true
  1. play rosbag
ros2 bag play --clock -r 0.5 /path_to_your_rosbag
  1. output visibility score in the terminal
ros2 topic echo /sensing/lidar/top/ring_outlier_filter/debug/visibility

get the following result

---
stamp:
  sec: 1707114299
  nanosec: 200355584
data: 0.6482204794883728
---
stamp:
  sec: 1707114299
  nanosec: 300320000
data: 0.6338975429534912
---

Effects on system behavior

not applicable

Interface changes

not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels May 14, 2024
@kyoichi-sugahara kyoichi-sugahara force-pushed the feat/calculate_visibility_score_ring_outlier_filter branch from 8ef4df8 to 35da49d Compare May 14, 2024 16:29
@github-actions github-actions bot removed the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label May 14, 2024
@kyoichi-sugahara kyoichi-sugahara force-pushed the feat/calculate_visibility_score_ring_outlier_filter branch from 35da49d to e843b53 Compare May 14, 2024 16:45
@kyoichi-sugahara kyoichi-sugahara force-pushed the feat/calculate_visibility_score_ring_outlier_filter branch from e843b53 to 1d09b20 Compare May 14, 2024 16:46
@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review May 15, 2024 04:56
Signed-off-by: kyoichi-sugahara <[email protected]>
@yukkysaito
Copy link
Contributor

Can you add an algorithm summary to the readme?

@kyoichi-sugahara
Copy link
Contributor Author

@yukkysaito
Updated document in c61dab9

@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 16, 2024
@knzo25
Copy link
Contributor

knzo25 commented May 17, 2024

@vividf
I will be reviewing:
#6658
#6746

So please review this one in the meantime

Edit: I pasted the wrong links. Now they are the correct ones

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyoichi-sugahara kyoichi-sugahara merged commit 81a75f7 into autowarefoundation:main May 17, 2024
32 of 35 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the feat/calculate_visibility_score_ring_outlier_filter branch May 17, 2024 02:52
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…lier filter (autowarefoundation#7011)

* calculate visibility score in ring outlier filter

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants