-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pointcloud_preprocessor): calculate visibility score in ring outlier filter #7011
Merged
kyoichi-sugahara
merged 5 commits into
autowarefoundation:main
from
kyoichi-sugahara:feat/calculate_visibility_score_ring_outlier_filter
May 17, 2024
Merged
feat(pointcloud_preprocessor): calculate visibility score in ring outlier filter #7011
kyoichi-sugahara
merged 5 commits into
autowarefoundation:main
from
kyoichi-sugahara:feat/calculate_visibility_score_ring_outlier_filter
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kyoichi-sugahara <[email protected]>
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:sensing
Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
labels
May 14, 2024
kyoichi-sugahara
force-pushed
the
feat/calculate_visibility_score_ring_outlier_filter
branch
from
May 14, 2024 16:29
8ef4df8
to
35da49d
Compare
github-actions
bot
removed
the
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
label
May 14, 2024
kyoichi-sugahara
force-pushed
the
feat/calculate_visibility_score_ring_outlier_filter
branch
from
May 14, 2024 16:45
35da49d
to
e843b53
Compare
Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara
force-pushed
the
feat/calculate_visibility_score_ring_outlier_filter
branch
from
May 14, 2024 16:46
e843b53
to
1d09b20
Compare
kyoichi-sugahara
requested review from
amc-nu,
badai-nguyen,
knzo25,
miursh,
vividf,
YoshiRi and
yukkysaito
as code owners
May 15, 2024 04:56
Signed-off-by: kyoichi-sugahara <[email protected]>
Can you add an algorithm summary to the readme? |
…_filter Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
@yukkysaito |
kyoichi-sugahara
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
May 16, 2024
yukkysaito
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kyoichi-sugahara
merged commit May 17, 2024
81a75f7
into
autowarefoundation:main
32 of 35 checks passed
kyoichi-sugahara
deleted the
feat/calculate_visibility_score_ring_outlier_filter
branch
May 17, 2024 02:52
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…lier filter (autowarefoundation#7011) * calculate visibility score in ring outlier filter Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:sensing
Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
calculate visibility score based on oulier pointcloud.
This feature is disabled by default with
publish_outlier_pointcloud
Tests performed
get the following result
Effects on system behavior
not applicable
Interface changes
not applicable
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.