Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cgroup setter node #6977

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

style(pre-commit): autofix

7ff7a64
Select commit
Loading
Failed to load commit list.
Open

feat: add cgroup setter node #6977

style(pre-commit): autofix
7ff7a64
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed May 13, 2024 in 41s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 4 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Overall Code Complexity cgroup_setter.cpp
  • Deep, Nested Complexity cgroup_setter.cpp: CgroupSetter::checkProcessAndAddToCgroup
  • Complex Method cgroup_setter.cpp: CgroupSetter::checkProcessAndAddToCgroup
  • Bumpy Road Ahead cgroup_setter.cpp: CgroupSetter::checkProcessAndAddToCgroup

Annotations

Check warning on line 140 in system/cgroup_setter/src/cgroup_setter.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

CgroupSetter::checkProcessAndAddToCgroup has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 140 in system/cgroup_setter/src/cgroup_setter.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

CgroupSetter::checkProcessAndAddToCgroup has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 1 in system/cgroup_setter/src/cgroup_setter.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Overall Code Complexity

This module has a mean cyclomatic complexity of 4.86 across 7 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check warning on line 140 in system/cgroup_setter/src/cgroup_setter.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

CgroupSetter::checkProcessAndAddToCgroup has a nested complexity depth of 5, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.