Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cgroup setter node #6977

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

TetsuKawa
Copy link
Contributor

Description

This PR adds cgroup setter node which attach processes to your custom cgroup.

Related links

Tests performed

  • Confirmed that this node attach processes to some custom cgroups.
  • Confirmed that this node output error logs when it fail to write attach processes to a cgroup, pgrep fail to find a pid, or the config file is wrong.
  • Confirmed that this node publish proper /diagnostics.

Notes for reviewers

Assumptions, Write permission is required for a custom cgroup, and /sys/fs/cgroup/cgroup.procs to attach a PID to the cgroup.

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TetsuKawa TetsuKawa self-assigned this May 10, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:system System design and integration. (auto-assigned) labels May 10, 2024
@TetsuKawa TetsuKawa requested a review from ito-san May 10, 2024 10:16
@TetsuKawa TetsuKawa added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed type:documentation Creating or refining documentation. (auto-assigned) component:system System design and integration. (auto-assigned) labels May 10, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:system System design and integration. (auto-assigned) labels May 10, 2024
@TetsuKawa TetsuKawa marked this pull request as ready for review May 13, 2024 02:20
Copy link

stale bot commented Jul 12, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 97 lines in your changes missing coverage. Please review.

Project coverage is 14.97%. Comparing base (f36005b) to head (7ff7a64).
Report is 972 commits behind head on main.

Files Patch % Lines
system/cgroup_setter/src/cgroup_setter.cpp 0.00% 97 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6977      +/-   ##
==========================================
- Coverage   14.98%   14.97%   -0.02%     
==========================================
  Files        1933     1934       +1     
  Lines      133069   133166      +97     
  Branches    39707    39730      +23     
==========================================
  Hits        19940    19940              
- Misses      90907    91004      +97     
  Partials    22222    22222              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.98% <ø> (ø) Carriedforward from f36005b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r
Copy link
Member

@TetsuKawa @ito-san Do you still need this modification?

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants