refactor(motion_utils): supress log message with rclcpp logging #6955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulfaqar-azmi-t4
requested review from
kosuke55,
satoshi-ota,
TakaHoribe,
rej55,
soblin,
taikitanaka3,
takayuki5168 and
tkimura4
as code owners
github-actions
bot
added
the
component:common
zulfaqar-azmi-t4
added
the
run:build-and-test-differential
takayuki5168
approved these changes
May 10, 2024
3 tasks
zulfaqar-azmi-t4
force-pushed
the
motion-utils-logger
branch
2 times, most recently
from
8e451e1 to
db3e781
Compare
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
force-pushed
the
motion-utils-logger
branch
from
db3e781 to
0bd6a66
Compare
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
satoshi-ota
approved these changes
May 17, 2024
zulfaqar-azmi-t4
merged commit e42fd71
into
autowarefoundation:main
21 of 22 checks passed
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…warefoundation#6955) * refactor(motion_utils): supress log message with rclcpp logging Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * remove std string Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 7, 2024
…warefoundation#6955) * refactor(motion_utils): supress log message with rclcpp logging Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * remove std string Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use rclcpp logging instead so that we can control the log with logging level configure plugin.
Directly use RCLCPP::DEBUG instead of common function, because it allows us to see which line in the the code is actually printing the messages.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.