Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build_depends): add glog-vendor #6952

Merged
merged 2 commits into from
May 9, 2024

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented May 9, 2024

Description

Add glog for build_depends.repos in universe.
Examples for use: #6792

Related links

#6792

Tests performed

Run ci & build in local.

Notes for reviewers

This will add glog with v0.6.0

Interface changes

None

ROS Topic Changes

None

ROS Parameter Changes

None

Effects on system behavior

This will add glog with v0.6.0 in CI

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TakaHoribe TakaHoribe requested a review from xmfcx May 9, 2024 02:02
@TakaHoribe TakaHoribe added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 9, 2024
@xmfcx
Copy link
Contributor

xmfcx commented May 9, 2024

Could've added it as part of #6792 😅

build_depends.repos Outdated Show resolved Hide resolved
Co-authored-by: M. Fatih Cırıt <[email protected]>
@TakaHoribe
Copy link
Contributor Author

Oops, sorry 😅

@xmfcx xmfcx enabled auto-merge (squash) May 9, 2024 02:14
@xmfcx xmfcx merged commit b5b7f95 into autowarefoundation:main May 9, 2024
23 checks passed
vividf pushed a commit to vividf/autoware.universe that referenced this pull request May 16, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
@TakaHoribe TakaHoribe deleted the add-glog-build-depend branch July 31, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants