-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(glog): add initialization check #6792
Conversation
@TakaHoribe we used https://github.com/bombela/backward-cpp before for similar purposes and it was really good at printing the causes of segfaults. Maybe you can try it too. |
Also you need to add
to |
It seems they made a ROS 2 package for it too: https://github.com/pal-robotics/backward_ros
Tested again and it works: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the localization packages 👍
pose_estimator_arbiter
yabloc_common
yabloc_particle_filter
ndt_scan_matcher
@xmfcx Thank you for the investigation of backward-cpp. Let me merge this PR first. The backward-cpp looks much better than glog, but it still has an issue with ros-component. If the issue is sloved, I want to replace all glog with backward-cpp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, I agree.
@TakaHoribe could you rebase to latest main? The CI is failing. |
4999452
to
df57e69
Compare
From above: #6792 (comment)
Or CI won't pass. I thought we added this before but it was here. @TakaHoribe |
I could add it too but you should Allow edits from maintainers on the PR. |
Now needs to be rebased again 🙏 |
Signed-off-by: Takamasa Horibe <[email protected]>
df57e69
to
d40be32
Compare
Signed-off-by: Takamasa Horibe <[email protected]> Signed-off-by: vividf <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Description
Add
IsGoogleLoggingInitialized()
check before glog initialization as the multiple initializations terminate the process.Related links
Must be merged after
Tests performed
kill -15 <pid>
should show the stack trace for the glog-installed process, e.g.map_based_prediction
Notes for reviewers
None
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.