-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_perception_launch): downsample perception input pointcloud #6886
Merged
YoshiRi
merged 6 commits into
autowarefoundation:main
from
YoshiRi:feat/downsapmple_perception_input_pointclouds
May 13, 2024
Merged
feat(tier4_perception_launch): downsample perception input pointcloud #6886
YoshiRi
merged 6 commits into
autowarefoundation:main
from
YoshiRi:feat/downsapmple_perception_input_pointclouds
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yoshiri <[email protected]>
github-actions
bot
added
the
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
label
Apr 25, 2024
Signed-off-by: yoshiri <[email protected]>
YoshiRi
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Apr 26, 2024
Signed-off-by: yoshiri <[email protected]>
github-actions
bot
added
the
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
label
Apr 26, 2024
yukkysaito
reviewed
Apr 26, 2024
github-actions
bot
removed
the
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
label
May 9, 2024
Signed-off-by: yoshiri <[email protected]>
yukkysaito
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7 tasks
vividf
pushed a commit
to vividf/autoware.universe
that referenced
this pull request
May 16, 2024
…autowarefoundation#6886) * feat: downsample perception input pointcloud Signed-off-by: yoshiri <[email protected]> * fix: add group if to switch downsample node Signed-off-by: yoshiri <[email protected]> * fix: add test and exec depend Signed-off-by: yoshiri <[email protected]> * Update launch/tier4_perception_launch/launch/perception.launch.xml Co-authored-by: Yukihiro Saito <[email protected]> * chore: refactor perception.launch.xml Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]> Co-authored-by: Yukihiro Saito <[email protected]> Signed-off-by: vividf <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…autowarefoundation#6886) * feat: downsample perception input pointcloud Signed-off-by: yoshiri <[email protected]> * fix: add group if to switch downsample node Signed-off-by: yoshiri <[email protected]> * fix: add test and exec depend Signed-off-by: yoshiri <[email protected]> * Update launch/tier4_perception_launch/launch/perception.launch.xml Co-authored-by: Yukihiro Saito <[email protected]> * chore: refactor perception.launch.xml Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]> Co-authored-by: Yukihiro Saito <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables user to use downsampled pointcloud for whole perception process.
Recently, fast downsample filter was implemented by @yukkysaito in #6138.
With improvements in sensor performance, the number of point clouds from LiDAR is expected to continue to increase. Especially in large vehicles equipped with multiple LiDARs, it has been found that there is significant latency in subsequent processing (mainly ground segmentation), which is why there is a desire to limit the number of point clouds as much as possible.
Currently, there are no modules in perception that require dense point clouds, and in centerpoint, having too many input point clouds can lead to decreased recognition performance due to constraints on the number of input point clouds. Therefore, it is proposed to downsample the point clouds used in perception at the earliest stage.
Related links
Tests performed
See perception common scenario results
Tested with xx1-gen2 vehicle in TIER IV.
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.