Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(static_centerline_generator): add script to show diff of lanelet2 maps #6804

Merged
merged 4 commits into from
Apr 16, 2024

update

59284f3
Select commit
Loading
Failed to load commit list.
Merged

feat(static_centerline_generator): add script to show diff of lanelet2 maps #6804

update
59284f3
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Apr 16, 2024 in 43s

CodeScene PR Check

Code Health Quality Gates: OK

  • Declining Code Health: 3 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method show_lanelet2_map_diff.py: remove_diff_to_ignore
  • Complex Method show_lanelet2_map_diff.py: sort_attributes
  • Bumpy Road Ahead show_lanelet2_map_diff.py: sort_attributes

Annotations

Check warning on line 85 in planning/static_centerline_generator/scripts/show_lanelet2_map_diff.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

remove_diff_to_ignore has a cyclomatic complexity of 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 55 in planning/static_centerline_generator/scripts/show_lanelet2_map_diff.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

sort_attributes has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 55 in planning/static_centerline_generator/scripts/show_lanelet2_map_diff.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

sort_attributes has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.