Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pull over to autoware_state_panel of rviz #6540

Merged

Conversation

TetsuKawa
Copy link
Contributor

Description

This PR adds pull over indicator to AutowareStatePanel.
Since the pull over has already been added to MrmState.msg, it will not cause a build error.

Tests performed

Screencast.from.2024.03.04.17.23.27.webm

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Mar 4, 2024
@TetsuKawa TetsuKawa added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 4, 2024
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 15.19%. Comparing base (56ad4b4) to head (b64c679).
Report is 8 commits behind head on main.

Files Patch % Lines
...er4_state_rviz_plugin/src/autoware_state_panel.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6540      +/-   ##
==========================================
- Coverage   15.20%   15.19%   -0.01%     
==========================================
  Files        1851     1851              
  Lines      128434   128437       +3     
  Branches    39228    39228              
==========================================
  Hits        19522    19522              
- Misses      87122    87125       +3     
  Partials    21790    21790              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.20% <ø> (ø) Carriedforward from 56ad4b4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TetsuKawa TetsuKawa merged commit 7ef61a9 into autowarefoundation:main Mar 5, 2024
30 of 32 checks passed
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants