Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(tier4_metrics_rviz_plugin): add missing dependency #6321

Merged

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Feb 5, 2024

Description

Adds missing dependency. Waiting for ros/rosdistro#39791 to be merged in the rosdistro repository.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota
Copy link
Contributor

Hi @esteve ✋ I've already added dep to distro in ros/rosdistro#39705. So I think you can use rosdep command to install missing dependency. Please confirm that.

Additionally, could you remove this ansible task after merging this PR?

@esteve
Copy link
Contributor Author

esteve commented Feb 6, 2024

@satoshi-ota this PR is waiting on ros/rosdistro#39791 to use the correct name for the dependency, Qt5 development packages use the -dev suffix.

I'll remove the ansible task in a follow-up PR once this one is merged.

@esteve
Copy link
Contributor Author

esteve commented Feb 7, 2024

@satoshi-ota I've submitted autowarefoundation/autoware#4156 as a draft PR, I'll change it to ready for review once ros/rosdistro#39791 and this PR are merged.

@esteve
Copy link
Contributor Author

esteve commented Feb 8, 2024

@satoshi-ota now that ros/rosdistro#39791 has been merged, could you review this PR when you have a moment? Thanks 🙏

@esteve
Copy link
Contributor Author

esteve commented Feb 8, 2024

@satoshi-ota that was quick! 🙂 Thanks!

@esteve esteve enabled auto-merge (squash) February 8, 2024 10:18
@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 8, 2024
@satoshi-ota
Copy link
Contributor

@esteve LGTM. Thanks 👍

@esteve esteve merged commit 77ad201 into autowarefoundation:main Feb 8, 2024
30 checks passed
@esteve esteve deleted the tier4-metrics-rviz-plugin-fix-dep branch February 8, 2024 10:59
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants