-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(tier4_metrics_rviz_plugin): add missing dependency #6321
build(tier4_metrics_rviz_plugin): add missing dependency #6321
Conversation
Signed-off-by: Esteve Fernandez <[email protected]>
Hi @esteve ✋ I've already added dep to distro in ros/rosdistro#39705. So I think you can use rosdep command to install missing dependency. Please confirm that. Additionally, could you remove this ansible task after merging this PR? |
@satoshi-ota this PR is waiting on ros/rosdistro#39791 to use the correct name for the dependency, Qt5 development packages use the I'll remove the ansible task in a follow-up PR once this one is merged. |
@satoshi-ota I've submitted autowarefoundation/autoware#4156 as a draft PR, I'll change it to ready for review once ros/rosdistro#39791 and this PR are merged. |
@satoshi-ota now that ros/rosdistro#39791 has been merged, could you review this PR when you have a moment? Thanks 🙏 |
@satoshi-ota that was quick! 🙂 Thanks! |
@esteve LGTM. Thanks 👍 |
…ndation#6321) Signed-off-by: Esteve Fernandez <[email protected]>
…ndation#6321) Signed-off-by: Esteve Fernandez <[email protected]>
Description
Adds missing dependency. Waiting for ros/rosdistro#39791 to be merged in the
rosdistro
repository.Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.