Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ansible): remove task installing libqt5charts5-dev #4156

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Feb 7, 2024

Description

Removed this task since this is handled by rosdep, see ros/rosdistro#39705 autowarefoundation/autoware.universe#6321 ros/rosdistro#39791

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@esteve esteve marked this pull request as ready for review February 8, 2024 11:00
@esteve esteve enabled auto-merge (squash) February 8, 2024 11:01
@esteve esteve requested a review from satoshi-ota February 8, 2024 11:01
@esteve
Copy link
Contributor Author

esteve commented Feb 8, 2024

@satoshi-ota now that autowarefoundation/autoware.universe#6321 is merged, could you have a look at this PR? Thanks.

@esteve esteve merged commit 2c2edff into main Feb 8, 2024
19 checks passed
@esteve esteve deleted the remove-qt5-charts-ansible branch February 8, 2024 14:20
@esteve
Copy link
Contributor Author

esteve commented Feb 8, 2024

@mitsudome-r thanks for the prompt review 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants