-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(avoidance): check traffic light info in order to limit drivable area #6016
Merged
satoshi-ota
merged 2 commits into
autowarefoundation:main
from
satoshi-ota:feat/limit-drivable-area
Jan 10, 2024
Merged
feat(avoidance): check traffic light info in order to limit drivable area #6016
satoshi-ota
merged 2 commits into
autowarefoundation:main
from
satoshi-ota:feat/limit-drivable-area
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Jan 5, 2024
satoshi-ota
requested review from
danielsanchezaran,
rej55,
kosuke55,
soblin,
maxime-clem,
shmpwk,
TakaHoribe,
takayuki5168,
tkimura4,
zulfaqar-azmi-t4,
kyoichi-sugahara and
TomohitoAndo
as code owners
January 5, 2024 07:42
Signed-off-by: satoshi-ota <[email protected]>
…area Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
force-pushed
the
feat/limit-drivable-area
branch
from
January 5, 2024 07:43
3c94761
to
716da8d
Compare
satoshi-ota
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jan 10, 2024
kyoichi-sugahara
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
rej55
approved these changes
Jan 10, 2024
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 11, 2024
…area (autowarefoundation#6016) * feat(avoidance): don't use opposite lane before intersection Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): check traffic light info in order to limit drivable area Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
4 tasks
zulfaqar-azmi-t4
pushed a commit
to zulfaqar-azmi-t4/autoware.universe
that referenced
this pull request
Jan 11, 2024
…area (autowarefoundation#6016) * feat(avoidance): don't use opposite lane before intersection Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): check traffic light info in order to limit drivable area Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 8, 2024
…area (autowarefoundation#6016) * feat(avoidance): don't use opposite lane before intersection Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): check traffic light info in order to limit drivable area Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
TomohitoAndo
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 1, 2024
…area (autowarefoundation#6016) * feat(avoidance): don't use opposite lane before intersection Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): check traffic light info in order to limit drivable area Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 8, 2024
…area (autowarefoundation#6016) * feat(avoidance): don't use opposite lane before intersection Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): check traffic light info in order to limit drivable area Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 8, 2024
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…area (autowarefoundation#6016) * feat(avoidance): don't use opposite lane before intersection Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): check traffic light info in order to limit drivable area Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…area (autowarefoundation#6016) * feat(avoidance): don't use opposite lane before intersection Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): check traffic light info in order to limit drivable area Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…area (autowarefoundation#6016) * feat(avoidance): don't use opposite lane before intersection Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): check traffic light info in order to limit drivable area Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…area (autowarefoundation#6016) * feat(avoidance): don't use opposite lane before intersection Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): check traffic light info in order to limit drivable area Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 6, 2024
…area (autowarefoundation#6016) * feat(avoidance): don't use opposite lane before intersection Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): check traffic light info in order to limit drivable area Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, avoidance module always expanded drivable area as much as possible. However, sometimes it blocked vehicle on opposite lane when the ego was waiting for red traffic light. In this situation, the ego basically should NOT straddle lane bound if there is possibility to stop by traffic signal.
After this PR, the module limits drivable lanes expansion and generates avoidance path within current lane when the ego is going to stop at stop line by traffic signal.
NOTE: expansion of the drivable area ONLY the lanelet in front of the intersection.
Tests performed
NOTE: When traffic siganl is GREEN signal, the module uses right/left lane in order to avoid objects.
Effects on system behavior
Improve avoidance behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.