Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): check traffic light info in order to limit drivable area #6016

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jan 5, 2024

Description

Previously, avoidance module always expanded drivable area as much as possible. However, sometimes it blocked vehicle on opposite lane when the ego was waiting for red traffic light. In this situation, the ego basically should NOT straddle lane bound if there is possibility to stop by traffic signal.

image

After this PR, the module limits drivable lanes expansion and generates avoidance path within current lane when the ego is going to stop at stop line by traffic signal.

  const auto update_left_lanelets = [&](const lanelet::ConstLanelet & target_lane) {
    const auto next_lanes = route_handler->getNextLanelets(target_lane);
    const auto is_stop_signal = utils::traffic_light::isTrafficSignalStop(next_lanes, planner_data);
    if (is_stop_signal && !in_avoidance_maneuver) {
      return;
    }
    const auto all_left_lanelets = route_handler->getAllLeftSharedLinestringLanelets(
      target_lane, parameters->use_opposite_lane, true);
    if (!all_left_lanelets.empty()) {
      current_drivable_lanes.left_lane = all_left_lanelets.back();  // leftmost lanelet
      pushUniqueVector(
        current_drivable_lanes.middle_lanes,
        lanelet::ConstLanelets(all_left_lanelets.begin(), all_left_lanelets.end() - 1));
    }
  };

NOTE: expansion of the drivable area ONLY the lanelet in front of the intersection.
image

Tests performed

NOTE: When traffic siganl is GREEN signal, the module uses right/left lane in order to avoid objects.
image

  • PASS TIER IV INTERNAL SCENARIOS

Effects on system behavior

Improve avoidance behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 5, 2024
@satoshi-ota satoshi-ota marked this pull request as ready for review January 5, 2024 07:42
@satoshi-ota satoshi-ota force-pushed the feat/limit-drivable-area branch from 3c94761 to 716da8d Compare January 5, 2024 07:43
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 10, 2024
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satoshi-ota satoshi-ota enabled auto-merge (squash) January 10, 2024 10:18
@satoshi-ota satoshi-ota merged commit f2936f0 into autowarefoundation:main Jan 10, 2024
31 of 33 checks passed
@satoshi-ota satoshi-ota deleted the feat/limit-drivable-area branch January 10, 2024 23:14
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jan 11, 2024
…area (autowarefoundation#6016)

* feat(avoidance): don't use opposite lane before intersection

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): check traffic light info in order to limit drivable area

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
zulfaqar-azmi-t4 pushed a commit to zulfaqar-azmi-t4/autoware.universe that referenced this pull request Jan 11, 2024
…area (autowarefoundation#6016)

* feat(avoidance): don't use opposite lane before intersection

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): check traffic light info in order to limit drivable area

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Mar 8, 2024
…area (autowarefoundation#6016)

* feat(avoidance): don't use opposite lane before intersection

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): check traffic light info in order to limit drivable area

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Apr 1, 2024
…area (autowarefoundation#6016)

* feat(avoidance): don't use opposite lane before intersection

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): check traffic light info in order to limit drivable area

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Apr 8, 2024
…area (autowarefoundation#6016)

* feat(avoidance): don't use opposite lane before intersection

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): check traffic light info in order to limit drivable area

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Apr 8, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…area (autowarefoundation#6016)

* feat(avoidance): don't use opposite lane before intersection

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): check traffic light info in order to limit drivable area

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…area (autowarefoundation#6016)

* feat(avoidance): don't use opposite lane before intersection

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): check traffic light info in order to limit drivable area

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…area (autowarefoundation#6016)

* feat(avoidance): don't use opposite lane before intersection

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): check traffic light info in order to limit drivable area

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…area (autowarefoundation#6016)

* feat(avoidance): don't use opposite lane before intersection

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): check traffic light info in order to limit drivable area

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jun 6, 2024
…area (autowarefoundation#6016)

* feat(avoidance): don't use opposite lane before intersection

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): check traffic light info in order to limit drivable area

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants