Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(multi_object_tracker): put node parameters to yaml file #5769

Merged
merged 3 commits into from
Dec 8, 2023
Merged

refactor(multi_object_tracker): put node parameters to yaml file #5769

merged 3 commits into from
Dec 8, 2023

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Dec 4, 2023 •
edited
Loading

Description

This PR aims:

  • put multi_object_tracker node parameters to yaml file and remove default parameter
  • fix unnecessary launch description in both this package and tier4_perception_launch

Merge this after autowarefoundation/autoware_launch#718.

Tests performed

Tested with Lsim and it works.

Effects on system behavior

Need to fix autoware_launch first.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Dec 4, 2023
@YoshiRi
update README
183230b 
Signed-off-by: yoshiri <[email protected]>
@YoshiRi YoshiRi marked this pull request as ready for review December 4, 2023 14:54
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Dec 4, 2023
@YoshiRi YoshiRi added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed type:documentation Creating or refining documentation. (auto-assigned) labels Dec 4, 2023
@YoshiRi YoshiRi mentioned this pull request Dec 4, 2023
Merged
4 tasks
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Dec 4, 2023
miursh
miursh reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoware.universe/launch/tier4_perception_launch/launch/object_recognition/tracking/tracking.launch.xml

Line 38 in 183230b

<arg name="publish_rate" value="$(var publish_rate)"/>
should be removed as well.

launch/tier4_perception_launch/launch/object_recognition/tracking/tracking.launch.xml Outdated Show resolved Hide resolved
@YoshiRi YoshiRi requested a review from scepter914 as a code owner December 5, 2023 06:31
miursh
miursh approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (6ad2f63) 0.00%.
Report is 158 commits behind head on main.

Files Patch % Lines
...i_object_tracker/src/multi_object_tracker_core.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #5769       +/-   ##
==========================================
- Coverage   15.32%   0.00%   -15.33%     
==========================================
  Files        1721      37     -1684     
  Lines      118559    2547   -116012     
  Branches    37995       0    -37995     
==========================================
- Hits        18169       0    -18169     
+ Misses      79657    2547    -77110     
+ Partials    20733       0    -20733
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YoshiRi
Copy link
Contributor Author

YoshiRi commented Dec 6, 2023

Need to merge Psim fix autowarefoundation/autoware_launch#724 before this PR.

@YoshiRi YoshiRi enabled auto-merge (squash) December 8, 2023 01:18
@YoshiRi YoshiRi disabled auto-merge December 8, 2023 01:24
@miursh miursh merged commit aeb461a into autowarefoundation:main Dec 8, 2023
21 of 25 checks passed
@YoshiRi YoshiRi deleted the feat/rework_tracking_parameters branch December 8, 2023 01:24
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
@YoshiRi @danielsanchezaran
refactor(multi_object_tracker): put node parameters to yaml file (aut…
e09cc25 
…owarefoundation#5769)

* rework multi object tracker parameters

Signed-off-by: yoshiri <[email protected]>

* update README

Signed-off-by: yoshiri <[email protected]>

* rework radar tracker parameter too

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
@YoshiRi @karishma1911
refactor(multi_object_tracker): put node parameters to yaml file (aut…
e8e06ac 
…owarefoundation#5769)

* rework multi object tracker parameters

Signed-off-by: yoshiri <[email protected]>

* update README

Signed-off-by: yoshiri <[email protected]>

* rework radar tracker parameter too

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
@YoshiRi @karishma1911
refactor(multi_object_tracker): put node parameters to yaml file (aut…
9715a7e 
…owarefoundation#5769)

* rework multi object tracker parameters

Signed-off-by: yoshiri <[email protected]>

* update README

Signed-off-by: yoshiri <[email protected]>

* rework radar tracker parameter too

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
Signed-off-by: karishma <[email protected]>
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Dec 20, 2023
Merged
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
@YoshiRi @karishma1911
refactor(multi_object_tracker): put node parameters to yaml file (aut…
6cba631 
…owarefoundation#5769)

* rework multi object tracker parameters

Signed-off-by: yoshiri <[email protected]>

* update README

Signed-off-by: yoshiri <[email protected]>

* rework radar tracker parameter too

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@YoshiRi @karishma1911
refactor(multi_object_tracker): put node parameters to yaml file (aut…
7730e88 
…owarefoundation#5769)

* rework multi object tracker parameters

Signed-off-by: yoshiri <[email protected]>

* update README

Signed-off-by: yoshiri <[email protected]>

* rework radar tracker parameter too

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@YoshiRi @karishma1911
refactor(multi_object_tracker): put node parameters to yaml file (aut…
318d71e 
…owarefoundation#5769)

* rework multi object tracker parameters

Signed-off-by: yoshiri <[email protected]>

* update README

Signed-off-by: yoshiri <[email protected]>

* rework radar tracker parameter too

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miursh miursh miursh approved these changes

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

@scepter914 scepter914 Awaiting requested review from scepter914

Assignees
No one assigned
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YoshiRi @miursh