Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(start_planner): add rss safety check function #5623

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Nov 18, 2023

Description

refactoring checkSafetyWithRSS

Tests performed

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55
Copy link
Contributor

If the function is completely the same, I want to move to common.

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 2212 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (983184b) 15.36%.
Report is 112 commits behind head on main.

Files Patch % Lines
...s/drivable_area_expansion/static_drivable_area.cpp 13.19% 597 Missing and 87 partials ⚠️
...anner/src/utils/avoidance/shift_line_generator.cpp 13.28% 431 Missing and 65 partials ⚠️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 3.90% 187 Missing and 10 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 0.60% 161 Missing and 2 partials ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 10.56% 110 Missing and 17 partials ⚠️
...ner/src/utils/path_safety_checker/safety_check.cpp 0.00% 100 Missing ⚠️
..._path_planner/src/marker_utils/avoidance/debug.cpp 0.00% 61 Missing ⚠️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 1.69% 58 Missing ⚠️
...cene_module/start_planner/start_planner_module.cpp 8.47% 54 Missing ⚠️
planning/behavior_path_planner/src/utils/utils.cpp 35.89% 31 Missing and 19 partials ⚠️
... and 22 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5623      +/-   ##
==========================================
+ Coverage   15.32%   15.36%   +0.03%     
==========================================
  Files        1721     1725       +4     
  Lines      118559   118540      -19     
  Branches    37995    38073      +78     
==========================================
+ Hits        18169    18209      +40     
+ Misses      79657    79559      -98     
- Partials    20733    20772      +39     
Flag Coverage Δ *Carryforward flag
differential 12.73% <12.04%> (?)
total 15.41% <28.57%> (+0.09%) ⬆️ Carriedforward from a2ba80e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara
Copy link
Contributor Author

kyoichi-sugahara commented Nov 21, 2023

@kosuke55

If the function is completely the same, I want to move to common.

I agree with that.
Is it ok to move to start_goal_planner_common?

@kosuke55
Copy link
Contributor

kosuke55 commented Nov 29, 2023

@kyoichi-sugahara sorry for the delay.

Is it ok to move to start_goal_planner_common?

yes ok!

@kyoichi-sugahara kyoichi-sugahara marked this pull request as draft November 30, 2023 03:02
@kyoichi-sugahara kyoichi-sugahara force-pushed the refactor/start_planner_rss branch from cba9ebd to ede15db Compare November 30, 2023 04:54
@kyoichi-sugahara
Copy link
Contributor Author

@kosuke55
The function is able to be moved to common without any issues, so I've moved it to common!
I'll check the evaluator result.

@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review November 30, 2023 04:59
@kyoichi-sugahara kyoichi-sugahara force-pushed the refactor/start_planner_rss branch from c5220d8 to b8146b3 Compare November 30, 2023 05:02
@kosuke55
Copy link
Contributor

LGTM

@kyoichi-sugahara
Copy link
Contributor Author

no degression so will merge

@kyoichi-sugahara kyoichi-sugahara enabled auto-merge (squash) November 30, 2023 07:08
@kyoichi-sugahara kyoichi-sugahara merged commit 6c85af4 into autowarefoundation:main Nov 30, 2023
25 of 28 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the refactor/start_planner_rss branch November 30, 2023 17:23
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…ation#5623)

* Refactor safety check method in StartPlannerModule

Signed-off-by: kyoichi-sugahara <[email protected]>

* Remove unused function checkSafetyWithRSS

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants