-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(start_planner): add rss safety check function #5623
refactor(start_planner): add rss safety check function #5623
Conversation
Signed-off-by: kyoichi-sugahara <[email protected]>
If the function is completely the same, I want to move to common. |
I agree with that. |
@kyoichi-sugahara sorry for the delay.
yes ok! |
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
cba9ebd
to
ede15db
Compare
@kosuke55 |
Signed-off-by: kyoichi-sugahara <[email protected]>
c5220d8
to
b8146b3
Compare
LGTM |
no degression so will merge |
6c85af4
into
autowarefoundation:main
…ation#5623) * Refactor safety check method in StartPlannerModule Signed-off-by: kyoichi-sugahara <[email protected]> * Remove unused function checkSafetyWithRSS Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]>
Description
refactoring checkSafetyWithRSS
Tests performed
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.