-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component_state_monitor): monitor pose_estimator output #5617
Merged
kminoda
merged 1 commit into
autowarefoundation:main
from
kminoda:feat/component_state_monitor/monitor_ndt_output
Nov 20, 2023
Merged
feat(component_state_monitor): monitor pose_estimator output #5617
kminoda
merged 1 commit into
autowarefoundation:main
from
kminoda:feat/component_state_monitor/monitor_ndt_output
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <[email protected]>
github-actions
bot
added
the
component:system
System design and integration. (auto-assigned)
label
Nov 17, 2023
Merged
4 tasks
isamu-takagi
approved these changes
Nov 17, 2023
kminoda
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Nov 17, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5617 +/- ##
=======================================
Coverage 15.32% 15.33%
=======================================
Files 1721 1721
Lines 118559 118486 -73
Branches 37995 37996 +1
=======================================
- Hits 18169 18168 -1
+ Misses 79657 79582 -75
- Partials 20733 20736 +3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shmpwk
approved these changes
Nov 17, 2023
TomohitoAndo
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 21, 2023
…efoundation#5617) Signed-off-by: kminoda <[email protected]>
Merged
4 tasks
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
…efoundation#5617) Signed-off-by: kminoda <[email protected]>
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
…efoundation#5617) (#1032) Signed-off-by: kminoda <[email protected]> Co-authored-by: kminoda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:system
System design and integration. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I would like to propose to monitor the output of
ndt_scan_matcher
which remains to be a critical source for accurate localization. Since most of the components assume that the localization is accurate, it is crucial to detect it's failure, and I would like to make the system as safe as possible with this PR.INTERNAL LINK 1
INTERNAL LINK 2
Should be merged with autowarefoundation/autoware_launch#692
Tests performed
Run logging simulator and confirmed that it does not raise any emergency (=False positives)
Effects on system behavior
This will surely increase the number of emergency, but we expect the amount to be quite limited. On the contrary, we will now be able to catch the state of NDT and raise emergency as quickly as possible, resulting in a safer system.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.