Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component_state_monitor): monitor pose_estimator output #5617

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Nov 17, 2023

Description

I would like to propose to monitor the output of ndt_scan_matcher which remains to be a critical source for accurate localization. Since most of the components assume that the localization is accurate, it is crucial to detect it's failure, and I would like to make the system as safe as possible with this PR.

INTERNAL LINK 1
INTERNAL LINK 2

Should be merged with autowarefoundation/autoware_launch#692

Tests performed

Run logging simulator and confirmed that it does not raise any emergency (=False positives)

Effects on system behavior

This will surely increase the number of emergency, but we expect the amount to be quite limited. On the contrary, we will now be able to catch the state of NDT and raise emergency as quickly as possible, resulting in a safer system.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Nov 17, 2023
@kminoda kminoda marked this pull request as draft November 17, 2023 07:44
@shmpwk shmpwk self-requested a review November 17, 2023 07:47
@kminoda kminoda requested a review from YamatoAndo November 17, 2023 07:54
@kminoda kminoda marked this pull request as ready for review November 17, 2023 08:05
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (f49fa9f) 15.33%.
Report is 23 commits behind head on main.

Files Patch % Lines
...rivable_area_expansion/drivable_area_expansion.cpp 40.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5617   +/-   ##
=======================================
  Coverage   15.32%   15.33%           
=======================================
  Files        1721     1721           
  Lines      118559   118486   -73     
  Branches    37995    37996    +1     
=======================================
- Hits        18169    18168    -1     
+ Misses      79657    79582   -75     
- Partials    20733    20736    +3     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.33% <40.00%> (+<0.01%) ⬆️ Carriedforward from 017aed4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda merged commit bf86f35 into autowarefoundation:main Nov 20, 2023
41 checks passed
@kminoda kminoda deleted the feat/component_state_monitor/monitor_ndt_output branch November 20, 2023 01:33
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Nov 21, 2023
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants