-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_path_planner): separate drivable area functions #5604
Merged
zulfaqar-azmi-t4
merged 1 commit into
autowarefoundation:main
from
zulfaqar-azmi-t4:refactor-static-drivable-area
Nov 21, 2023
Merged
refactor(behavior_path_planner): separate drivable area functions #5604
zulfaqar-azmi-t4
merged 1 commit into
autowarefoundation:main
from
zulfaqar-azmi-t4:refactor-static-drivable-area
Nov 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulfaqar-azmi-t4
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4 and
purewater0901
as code owners
November 16, 2023 03:48
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Nov 16, 2023
satoshi-ota
reviewed
Nov 16, 2023
...planner/include/behavior_path_planner/utils/drivable_area_expansion/static_drivable_area.hpp
Outdated
Show resolved
Hide resolved
zulfaqar-azmi-t4
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Nov 17, 2023
satoshi-ota
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
zulfaqar-azmi-t4
force-pushed
the
refactor-static-drivable-area
branch
from
November 20, 2023 03:03
91b3dcf
to
f694ae9
Compare
zulfaqar-azmi-t4
force-pushed
the
refactor-static-drivable-area
branch
from
November 20, 2023 07:48
f694ae9
to
77ebcb7
Compare
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
force-pushed
the
refactor-static-drivable-area
branch
from
November 20, 2023 08:37
77ebcb7
to
5820532
Compare
@kosuke55 How about is your review from goal planner side...? |
kosuke55
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!! thanks
zulfaqar-azmi-t4
merged commit Nov 21, 2023
cc9d2a6
into
autowarefoundation:main
19 of 23 checks passed
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
…towarefoundation#5604) Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Caution: Although this is not breaking changes, it still will create a lot of conflict for the present PR or during creation of experimental branch.
Previously, drivable area expansion algorithm was written in the
utils/utils.hpp
.With the new dynamic drivable area expansion feature added in the behavior path planner module, there is a necessity to separate the algorithm from
utils.hpp
into another file to prevent confusion when debugging drivable area related functions.Related links
None
Tests performed
Compile success
Notes for reviewers
None
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.