Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): separate drivable area functions #5604

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Nov 16, 2023

Description

Caution: Although this is not breaking changes, it still will create a lot of conflict for the present PR or during creation of experimental branch.

Previously, drivable area expansion algorithm was written in the utils/utils.hpp.
With the new dynamic drivable area expansion feature added in the behavior path planner module, there is a necessity to separate the algorithm from utils.hpp into another file to prevent confusion when debugging drivable area related functions.

Related links

None

Tests performed

Compile success

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 17, 2023
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the refactor-static-drivable-area branch from 91b3dcf to f694ae9 Compare November 20, 2023 03:03
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 enabled auto-merge (squash) November 20, 2023 03:10
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 975 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (5820532) 15.31%.
Report is 30 commits behind head on main.

Files Patch % Lines
...s/drivable_area_expansion/static_drivable_area.cpp 11.54% 623 Missing and 74 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 1.72% 113 Missing and 1 partial ⚠️
planning/behavior_path_planner/src/utils/utils.cpp 35.89% 31 Missing and 19 partials ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% 34 Missing and 2 partials ⚠️
...ing/behavior_path_planner/src/utils/path_utils.cpp 42.30% 0 Missing and 30 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.hpp 15.78% 15 Missing and 1 partial ⚠️
...th_planner/src/scene_module/lane_change/normal.cpp 0.00% 13 Missing ⚠️
...e/behavior_path_planner/utils/avoidance/helper.hpp 0.00% 4 Missing ⚠️
...ath_planner/src/scene_module/avoidance/manager.cpp 0.00% 0 Missing and 4 partials ⚠️
...cene_module/start_planner/start_planner_module.cpp 0.00% 3 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5604      +/-   ##
==========================================
- Coverage   15.32%   15.31%   -0.01%     
==========================================
  Files        1721     1722       +1     
  Lines      118559   118866     +307     
  Branches    37995    38267     +272     
==========================================
+ Hits        18169    18205      +36     
- Misses      79657    79889     +232     
- Partials    20733    20772      +39     
Flag Coverage Δ *Carryforward flag
differential 12.64% <13.41%> (?)
total 15.35% <40.00%> (+0.02%) ⬆️ Carriedforward from 017aed4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the refactor-static-drivable-area branch from f694ae9 to 77ebcb7 Compare November 20, 2023 07:48
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the refactor-static-drivable-area branch from 77ebcb7 to 5820532 Compare November 20, 2023 08:37
@satoshi-ota
Copy link
Contributor

@kosuke55 How about is your review from goal planner side...?

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!! thanks

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit cc9d2a6 into autowarefoundation:main Nov 21, 2023
19 of 23 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the refactor-static-drivable-area branch November 21, 2023 01:30
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants