-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): prevent sudden steering at avoidance maneuver #5572
Merged
satoshi-ota
merged 4 commits into
autowarefoundation:main
from
satoshi-ota:fix/prevent-sudden-steering
Nov 16, 2023
Merged
fix(avoidance): prevent sudden steering at avoidance maneuver #5572
satoshi-ota
merged 4 commits into
autowarefoundation:main
from
satoshi-ota:fix/prevent-sudden-steering
Nov 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Nov 14, 2023
satoshi-ota
force-pushed
the
fix/prevent-sudden-steering
branch
3 times, most recently
from
November 16, 2023 02:59
79baead
to
24a972e
Compare
Merged
5 tasks
satoshi-ota
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
November 16, 2023 03:04
satoshi-ota
commented
Nov 16, 2023
planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp
Show resolved
Hide resolved
satoshi-ota
changed the title
fix(avoidance): prevent sudden steering at yield maneuver
fix(avoidance): prevent sudden steering at avoidance maneuver
Nov 16, 2023
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
force-pushed
the
fix/prevent-sudden-steering
branch
from
November 16, 2023 06:20
24a972e
to
0d8c9cd
Compare
rej55
reviewed
Nov 16, 2023
planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp
Outdated
Show resolved
Hide resolved
…dance_module.cpp Co-authored-by: Fumiya Watanabe <[email protected]>
rej55
approved these changes
Nov 16, 2023
satoshi-ota
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Nov 16, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5572 +/- ##
==========================================
+ Coverage 15.32% 15.33% +0.01%
==========================================
Files 1721 1721
Lines 118559 118500 -59
Branches 37995 37991 -4
==========================================
+ Hits 18169 18173 +4
+ Misses 79657 79586 -71
- Partials 20733 20741 +8
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
satoshi-ota
added a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Nov 21, 2023
…refoundation#5572) * fix(avoidance): prevent sudden steering at yield maneuver Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): output debug info Signed-off-by: satoshi-ota <[email protected]> * Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp Co-authored-by: Fumiya Watanabe <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: satoshi-ota <[email protected]> Co-authored-by: Fumiya Watanabe <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
…refoundation#5572) * fix(avoidance): prevent sudden steering at yield maneuver Signed-off-by: satoshi-ota <[email protected]> * feat(avoidance): output debug info Signed-off-by: satoshi-ota <[email protected]> * Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp Co-authored-by: Fumiya Watanabe <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: satoshi-ota <[email protected]> Co-authored-by: Fumiya Watanabe <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at 3807905
Prevent sudden steering when approaching a shift line in the avoidance module. Add a condition to
canYieldManeuver
inavoidance_module.cpp
to check the distance to the shift line start point.Please review following PR at first:
autowarefoundation/autoware_launch#690
Add new parameter
min_prepare_time
.The module doesn't generate shift path whose start point is closer than
ego_speed * min_prepare_time
meter.Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.