Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): prevent sudden steering at avoidance maneuver #5572

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Nov 14, 2023

Description

🤖 Generated by Copilot at 3807905

Prevent sudden steering when approaching a shift line in the avoidance module. Add a condition to canYieldManeuver in avoidance_module.cpp to check the distance to the shift line start point.

Please review following PR at first:
autowarefoundation/autoware_launch#690


Add new parameter min_prepare_time.
The module doesn't generate shift path whose start point is closer than ego_speed * min_prepare_time meter.

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 14, 2023
@satoshi-ota satoshi-ota force-pushed the fix/prevent-sudden-steering branch 3 times, most recently from 79baead to 24a972e Compare November 16, 2023 02:59
@satoshi-ota satoshi-ota marked this pull request as ready for review November 16, 2023 03:04
@satoshi-ota satoshi-ota changed the title fix(avoidance): prevent sudden steering at yield maneuver fix(avoidance): prevent sudden steering at avoidance maneuver Nov 16, 2023
@satoshi-ota satoshi-ota force-pushed the fix/prevent-sudden-steering branch from 24a972e to 0d8c9cd Compare November 16, 2023 06:20
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (7657be1) 15.33%.
Report is 14 commits behind head on main.

Files Patch % Lines
.../scene_module/goal_planner/goal_planner_module.cpp 2.50% 39 Missing ⚠️
.../scene_module/goal_planner/goal_planner_module.hpp 0.00% 15 Missing ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% 13 Missing and 2 partials ⚠️
...ath_planner/src/scene_module/avoidance/manager.cpp 0.00% 0 Missing and 4 partials ⚠️
...rivable_area_expansion/drivable_area_expansion.cpp 40.00% 0 Missing and 3 partials ⚠️
...e/behavior_path_planner/utils/avoidance/helper.hpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5572      +/-   ##
==========================================
+ Coverage   15.32%   15.33%   +0.01%     
==========================================
  Files        1721     1721              
  Lines      118559   118500      -59     
  Branches    37995    37991       -4     
==========================================
+ Hits        18169    18173       +4     
+ Misses      79657    79586      -71     
- Partials    20733    20741       +8     
Flag Coverage Δ *Carryforward flag
differential 12.69% <3.70%> (?)
total 15.34% <40.00%> (+0.01%) ⬆️ Carriedforward from 017aed4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit b5c23b1 into autowarefoundation:main Nov 16, 2023
28 of 32 checks passed
@satoshi-ota satoshi-ota deleted the fix/prevent-sudden-steering branch November 16, 2023 08:11
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Nov 21, 2023
…refoundation#5572)

* fix(avoidance): prevent sudden steering at yield maneuver

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): output debug info

Signed-off-by: satoshi-ota <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: satoshi-ota <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
…refoundation#5572)

* fix(avoidance): prevent sudden steering at yield maneuver

Signed-off-by: satoshi-ota <[email protected]>

* feat(avoidance): output debug info

Signed-off-by: satoshi-ota <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: satoshi-ota <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants