-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(simple_planning_simulator): change default value of manual gear, DRIVE -> PARK #5563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is to prohibit unintentional start when the state is changed from Autonomous to Manual in the simulator.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5563 +/- ##
==========================================
+ Coverage 15.26% 15.27% +0.01%
==========================================
Files 1715 1715
Lines 118348 118203 -145
Branches 37906 37824 -82
==========================================
- Hits 18061 18054 -7
+ Misses 79634 79506 -128
+ Partials 20653 20643 -10
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…DRIVE -> PARK (backport autowarefoundation#5563) (#1026) fix(simple_planning_simulator): change default value of manual gear, DRIVE -> PARK (autowarefoundation#5563)
Description
The simple_planning_simulator unexpectedly move on the downhill, when enabling "enable_road_slope_simulation" and switching to manual mode .
This is because default gear of manual mode is DRIVE.
So, I'll change to PARK to resolve this.
Related links
TIERIV INTERNAL LINK
https://tier4.atlassian.net/browse/RT0-29756
Tests performed
Map: sample_map from https://autowarefoundation.github.io/autoware-documentation/main/tutorials/ad-hoc-simulation/planning-simulation/
Preparing:
enable_road_slope_simulation=True
to https://github.com/autowarefoundation/sample_vehicle_launch/blob/main/sample_vehicle_description/config/simulator_model.param.yaml#L8Procedure:
Before:
output-2023-11-13_18.21.34.mp4
After:
I confirmed ego vehicle does not move.
output-2023-11-13_18.16.58.mp4
Notes for reviewers
Interface changes
Effects on system behavior
After merging this PR, ego vehicle does not move just changing manual mode.
You have to change gear, DRIVE to PARK.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.