Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(simple_planning_simulator): change default value of manual gear, DRIVE -> PARK #5563

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Nov 13, 2023

Description

The simple_planning_simulator unexpectedly move on the downhill, when enabling "enable_road_slope_simulation" and switching to manual mode .
This is because default gear of manual mode is DRIVE.
So, I'll change to PARK to resolve this.

Related links

TIERIV INTERNAL LINK

https://tier4.atlassian.net/browse/RT0-29756

Tests performed

Map: sample_map from https://autowarefoundation.github.io/autoware-documentation/main/tutorials/ad-hoc-simulation/planning-simulation/

Preparing:

Procedure:

  • Start planning_simulator
    ros2 launch autoware_launch planning_simulator.launch.xml vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit map_path:=$HOME/map/sample_map
    
  • set initial pose
  • change AutowareControl to Disable

Before:

output-2023-11-13_18.21.34.mp4

After:

I confirmed ego vehicle does not move.

output-2023-11-13_18.16.58.mp4

Notes for reviewers

Interface changes

Effects on system behavior

After merging this PR, ego vehicle does not move just changing manual mode.
You have to change gear, DRIVE to PARK.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TakaHoribe TakaHoribe added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 14, 2023
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is to prohibit unintentional start when the state is changed from Autonomous to Manual in the simulator.

@h-ohta h-ohta enabled auto-merge (squash) November 14, 2023 06:05
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (88b06e0) 15.26% compared to head (f45a9e0) 15.27%.
Report is 7 commits behind head on main.

Files Patch % Lines
...nning_simulator/simple_planning_simulator_core.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5563      +/-   ##
==========================================
+ Coverage   15.26%   15.27%   +0.01%     
==========================================
  Files        1715     1715              
  Lines      118348   118203     -145     
  Branches    37906    37824      -82     
==========================================
- Hits        18061    18054       -7     
+ Misses      79634    79506     -128     
+ Partials    20653    20643      -10     
Flag Coverage Δ *Carryforward flag
differential 57.03% <0.00%> (?)
total 15.27% <ø> (+0.01%) ⬆️ Carriedforward from 88b06e0

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h-ohta h-ohta merged commit b902450 into main Nov 14, 2023
22 of 24 checks passed
@h-ohta h-ohta deleted the fix/simple_planning_sim_manual branch November 14, 2023 06:48
@xmfcx xmfcx added component:simulation Virtual environment setups and simulations. (auto-assigned) and removed component:simulator labels Nov 14, 2023
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Nov 20, 2023
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Nov 20, 2023
…DRIVE -> PARK (backport autowarefoundation#5563) (#1026)

fix(simple_planning_simulator): change default value of manual gear, DRIVE -> PARK (autowarefoundation#5563)
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants