Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(probabilistic_occupancy_grid_map): add synchronized ogm fusion node #5485

Merged

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Nov 5, 2023

Description

This PR aiming to rearrange #3107.
It enables to run occupancy grid map with multi lidar frame.

Related links

Related PR needed for test

Tests performed

Tested in gtest and lsim.
In the sample rosbag,

name figure processing_time
right lidar image 6ms
left lidar image 7ms
top lidar image 30ms
merged image 6ms
original single frame skip 31ms

latency comparison

original multi_lidar
191ms 201ms

Notes for reviewers

Please be sure all of following changes are merged in your repository.

Related PR needed for test

And then, set occupancy_grid_map_method in tier4_perception_component.launch.xml to multi_lidar_pointcloud_based_occupancy_grid_map.

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Summary by CodeRabbit

  • New Feature: Added search functionality to the UI, allowing users to easily find specific items.
  • Bug Fix: Resolved an issue where the application crashed when loading large datasets.
  • Documentation: Updated the README file with detailed instructions on how to set up and configure the application.
  • Refactor: Improved the performance of the data processing module, resulting in faster data analysis.
  • Style: Applied consistent formatting and naming conventions throughout the codebase for better readability.
  • Test: Added additional unit tests to ensure the reliability and accuracy of critical functions.
  • Chore: Upgraded dependencies to the latest versions to improve security and take advantage of new features.
  • Revert: Rolled back a previous change that caused compatibility issues with certain operating systems.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Nov 5, 2023
@YoshiRi
Copy link
Contributor Author

YoshiRi commented Nov 5, 2023

It seems launch_test for grid map fusion is not working well. Please wait for awhile.

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

@YoshiRi YoshiRi requested a review from miursh as a code owner December 16, 2023 15:21
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Dec 16, 2023
@github-actions github-actions bot removed type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jan 11, 2024
@YoshiRi YoshiRi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 4, 2024
@YoshiRi YoshiRi self-assigned this Mar 4, 2024
@YoshiRi YoshiRi marked this pull request as ready for review March 4, 2024 07:45
@YoshiRi

This comment was marked as outdated.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 14.77%. Comparing base (efe4e16) to head (ef35a7e).
Report is 13 commits behind head on main.

Files Patch % Lines
...d_map/pointcloud_based_occupancy_grid_map_node.cpp 0.00% 1 Missing and 2 partials ⚠️
...p/src/fusion/synchronized_grid_map_fusion_node.cpp 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5485      +/-   ##
==========================================
- Coverage   14.80%   14.77%   -0.03%     
==========================================
  Files        1915     1917       +2     
  Lines      132241   131656     -585     
  Branches    39318    39074     -244     
==========================================
- Hits        19574    19452     -122     
+ Misses      90835    90488     -347     
+ Partials    21832    21716     -116     
Flag Coverage Δ *Carryforward flag
differential 27.13% <16.66%> (?)
total 14.77% <ø> (-0.03%) ⬇️ Carriedforward from 39ac80c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YoshiRi
Copy link
Contributor Author

YoshiRi commented Mar 13, 2024

Additional check for OGM

There are about 2~5ms latency with OGM fusion.

❯ ros2 topic delay /perception/occupancy_grid_map/top_lidar/map --use-sim-time
1710310688.879334 [112]       ros2: determined wlp9s0 (udp/10.0.57.190) as highest quality interface, selected for automatic interface.
average delay: 0.168
        min: 0.157s max: 0.185s std dev: 0.00787s window: 9
average delay: 0.164
        min: 0.119s max: 0.205s std dev: 0.02166s window: 18

❯ ros2 topic delay /perception/occupancy_grid_map/map --use-sim-time
1710310681.473118 [112]       ros2: determined wlp9s0 (udp/10.0.57.190) as highest quality interface, selected for automatic interface.
average delay: 0.170
        min: 0.157s max: 0.185s std dev: 0.00779s window: 9
average delay: 0.166
        min: 0.129s max: 0.205s std dev: 0.02193s window: 18

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Mar 13, 2024
Copy link
Contributor

@soblin soblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@YoshiRi YoshiRi enabled auto-merge (squash) March 13, 2024 07:15
@YoshiRi YoshiRi merged commit 47d1212 into autowarefoundation:main Mar 13, 2024
25 of 27 checks passed
@YoshiRi YoshiRi deleted the feat/rearrange_grid_map_fusion branch March 13, 2024 10:31
YoshiRi added a commit to tier4/autoware.universe that referenced this pull request Mar 13, 2024
…ode (autowarefoundation#5485)

* add synchronized ogm fusion node

Signed-off-by: yoshiri <[email protected]>

* add launch test for grid map fusion node

Signed-off-by: yoshiri <[email protected]>

* fix test cases input msg error

Signed-off-by: yoshiri <[email protected]>

* change default fusion parameter

Signed-off-by: yoshiri <[email protected]>

* rename parameter for ogm fusion

Signed-off-by: yoshiri <[email protected]>

* feat: add multi_lidar_ogm generation method

Signed-off-by: yoshiri <[email protected]>

* enable ogm creation launcher in tier4_perception_launch to call multi_lidar ogm creation

Signed-off-by: yoshiri <[email protected]>

* fix: change ogm fusion node pub policy to reliable

Signed-off-by: yoshiri <[email protected]>

* fix: fix to use lidar frame as scan frame

Signed-off-by: Yoshi, Ri <[email protected]>

* fix: launcher node

Signed-off-by: Yoshi, Ri <[email protected]>

* feat: update param name

Signed-off-by: yoshiri <[email protected]>

* chore: fix ogm pointcloud subscription

Signed-off-by: yoshiri <[email protected]>

* feat: enable to publish pipeline latency

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
Signed-off-by: Yoshi, Ri <[email protected]>
yhisaki pushed a commit to yhisaki/autoware.universe that referenced this pull request Mar 15, 2024
…ode (autowarefoundation#5485)

* add synchronized ogm fusion node

Signed-off-by: yoshiri <[email protected]>

* add launch test for grid map fusion node

Signed-off-by: yoshiri <[email protected]>

* fix test cases input msg error

Signed-off-by: yoshiri <[email protected]>

* change default fusion parameter

Signed-off-by: yoshiri <[email protected]>

* rename parameter for ogm fusion

Signed-off-by: yoshiri <[email protected]>

* feat: add multi_lidar_ogm generation method

Signed-off-by: yoshiri <[email protected]>

* enable ogm creation launcher in tier4_perception_launch to call multi_lidar ogm creation

Signed-off-by: yoshiri <[email protected]>

* fix: change ogm fusion node pub policy to reliable

Signed-off-by: yoshiri <[email protected]>

* fix: fix to use lidar frame as scan frame

Signed-off-by: Yoshi, Ri <[email protected]>

* fix: launcher node

Signed-off-by: Yoshi, Ri <[email protected]>

* feat: update param name

Signed-off-by: yoshiri <[email protected]>

* chore: fix ogm pointcloud subscription

Signed-off-by: yoshiri <[email protected]>

* feat: enable to publish pipeline latency

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
Signed-off-by: Yoshi, Ri <[email protected]>
YoshiRi added a commit to tier4/autoware.universe that referenced this pull request Mar 20, 2024
…ode (autowarefoundation#5485)

* add synchronized ogm fusion node

Signed-off-by: yoshiri <[email protected]>

* add launch test for grid map fusion node

Signed-off-by: yoshiri <[email protected]>

* fix test cases input msg error

Signed-off-by: yoshiri <[email protected]>

* change default fusion parameter

Signed-off-by: yoshiri <[email protected]>

* rename parameter for ogm fusion

Signed-off-by: yoshiri <[email protected]>

* feat: add multi_lidar_ogm generation method

Signed-off-by: yoshiri <[email protected]>

* enable ogm creation launcher in tier4_perception_launch to call multi_lidar ogm creation

Signed-off-by: yoshiri <[email protected]>

* fix: change ogm fusion node pub policy to reliable

Signed-off-by: yoshiri <[email protected]>

* fix: fix to use lidar frame as scan frame

Signed-off-by: Yoshi, Ri <[email protected]>

* fix: launcher node

Signed-off-by: Yoshi, Ri <[email protected]>

* feat: update param name

Signed-off-by: yoshiri <[email protected]>

* chore: fix ogm pointcloud subscription

Signed-off-by: yoshiri <[email protected]>

* feat: enable to publish pipeline latency

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
Signed-off-by: Yoshi, Ri <[email protected]>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…ode (autowarefoundation#5485)

* add synchronized ogm fusion node

Signed-off-by: yoshiri <[email protected]>

* add launch test for grid map fusion node

Signed-off-by: yoshiri <[email protected]>

* fix test cases input msg error

Signed-off-by: yoshiri <[email protected]>

* change default fusion parameter

Signed-off-by: yoshiri <[email protected]>

* rename parameter for ogm fusion

Signed-off-by: yoshiri <[email protected]>

* feat: add multi_lidar_ogm generation method

Signed-off-by: yoshiri <[email protected]>

* enable ogm creation launcher in tier4_perception_launch to call multi_lidar ogm creation

Signed-off-by: yoshiri <[email protected]>

* fix: change ogm fusion node pub policy to reliable

Signed-off-by: yoshiri <[email protected]>

* fix: fix to use lidar frame as scan frame

Signed-off-by: Yoshi, Ri <[email protected]>

* fix: launcher node

Signed-off-by: Yoshi, Ri <[email protected]>

* feat: update param name

Signed-off-by: yoshiri <[email protected]>

* chore: fix ogm pointcloud subscription

Signed-off-by: yoshiri <[email protected]>

* feat: enable to publish pipeline latency

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
Signed-off-by: Yoshi, Ri <[email protected]>
Signed-off-by: kaigohirao <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ode (autowarefoundation#5485)

* add synchronized ogm fusion node

Signed-off-by: yoshiri <[email protected]>

* add launch test for grid map fusion node

Signed-off-by: yoshiri <[email protected]>

* fix test cases input msg error

Signed-off-by: yoshiri <[email protected]>

* change default fusion parameter

Signed-off-by: yoshiri <[email protected]>

* rename parameter for ogm fusion

Signed-off-by: yoshiri <[email protected]>

* feat: add multi_lidar_ogm generation method

Signed-off-by: yoshiri <[email protected]>

* enable ogm creation launcher in tier4_perception_launch to call multi_lidar ogm creation

Signed-off-by: yoshiri <[email protected]>

* fix: change ogm fusion node pub policy to reliable

Signed-off-by: yoshiri <[email protected]>

* fix: fix to use lidar frame as scan frame

Signed-off-by: Yoshi, Ri <[email protected]>

* fix: launcher node

Signed-off-by: Yoshi, Ri <[email protected]>

* feat: update param name

Signed-off-by: yoshiri <[email protected]>

* chore: fix ogm pointcloud subscription

Signed-off-by: yoshiri <[email protected]>

* feat: enable to publish pipeline latency

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
Signed-off-by: Yoshi, Ri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants