Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(camera_view_plugin): add camera view plugin package #5472

Merged

style(pre-commit): autofix

f1786b9
Select commit
Loading
Failed to load commit list.
Merged

feat(camera_view_plugin): add camera view plugin package #5472

style(pre-commit): autofix
f1786b9
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Nov 3, 2023 in 54s

CodeScene PR Check

Code Health Quality Gates: OK

  • Declining Code Health: 4 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Increased risk for defects: The change is more wide-spread in terms of lines of code than 99% of the historic high-risk change sets. The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method bird_eye_view_controller.cpp: BirdEyeViewController::handleMouseEvent
  • Complex Conditional bird_eye_view_controller.cpp: BirdEyeViewController::handleMouseEvent
  • Complex Method third_person_view_controller.cpp: ThirdPersonViewController::handleMouseEvent
  • Complex Conditional third_person_view_controller.cpp: ThirdPersonViewController::handleMouseEvent

Annotations

Check warning on line 153 in common/tier4_camera_view_rviz_plugin/src/bird_eye_view_controller.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

BirdEyeViewController::handleMouseEvent has a cyclomatic complexity of 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 131 in common/tier4_camera_view_rviz_plugin/src/bird_eye_view_controller.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

BirdEyeViewController::handleMouseEvent has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 184 in common/tier4_camera_view_rviz_plugin/src/third_person_view_controller.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

ThirdPersonViewController::handleMouseEvent has a cyclomatic complexity of 17, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 138 in common/tier4_camera_view_rviz_plugin/src/third_person_view_controller.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

ThirdPersonViewController::handleMouseEvent has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.