-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(camera_view_plugin): add camera view plugin package #5472
feat(camera_view_plugin): add camera view plugin package #5472
Conversation
Signed-off-by: Owen-Liuyuxuan <[email protected]>
Signed-off-by: Owen-Liuyuxuan <[email protected]>
@Owen-Liuyuxuan ex. |
Signed-off-by: Owen-Liuyuxuan <[email protected]>
Signed-off-by: Owen-Liuyuxuan <[email protected]>
Head branch was pushed to by a user without write access
@tkimura4 Sorry I may have interrupted the auto-merge with a commit to fixing the license problem. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5472 +/- ##
==========================================
- Coverage 14.84% 14.80% -0.05%
==========================================
Files 1665 1672 +7
Lines 116233 116572 +339
Branches 36257 36257
==========================================
Hits 17259 17259
- Misses 79474 79813 +339
Partials 19500 19500
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
common/tier4_camera_view_rviz_plugin/src/bird_eye_view_controller.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Owen-Liuyuxuan <[email protected]>
@shmpwk |
The spell-check-partial action succeeded. |
…ndation#5472) * add camera view plugin package Signed-off-by: Owen-Liuyuxuan <[email protected]> * add readme for short cut Signed-off-by: Owen-Liuyuxuan <[email protected]> * style(pre-commit): autofix * change name Signed-off-by: Owen-Liuyuxuan <[email protected]> * style(pre-commit): autofix * fix license Signed-off-by: Owen-Liuyuxuan <[email protected]> * fix license Signed-off-by: Owen-Liuyuxuan <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Owen-Liuyuxuan <[email protected]> Co-authored-by: Owen-Liuyuxuan <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
In testing the system, sometimes frequently switching from a third-person view following the vehicle and a bird-eye view focusing on the vehicle is needed.
This PR adds two buttons RViz plugin for convenient switching between the two views.
Related links
#5469
Tests performed
PSim
Notes for reviewers
Interface changes
Because operation view only makes sense when it is looking at the vehicle. So in code we force the target frame of operation view being
base_link
.Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.