Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(trtexec_vendor): fix cmake to find trtexec bin #5464

Closed
wants to merge 3 commits into from

Conversation

felixf4xu
Copy link
Contributor

@felixf4xu felixf4xu commented Nov 1, 2023

Description

This pr fixes #5453

Tests performed

cmake build of trtexec_vendor

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Nov 1, 2023
@wep21 wep21 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 2, 2023
Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wep21 wep21 enabled auto-merge (squash) November 2, 2023 00:36
auto-merge was automatically disabled November 15, 2023 08:46

Head branch was pushed to by a user without write access

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (fffcc61) 15.32%.
Report is 98 commits behind head on main.

❗ Current head fffcc61 differs from pull request most recent head 9ae9d03. Consider uploading reports for the commit 9ae9d03 to get more accurate results

Files Patch % Lines
...rivable_area_expansion/drivable_area_expansion.cpp 40.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5464      +/-   ##
==========================================
- Coverage   15.32%   15.32%   -0.01%     
==========================================
  Files        1721     1721              
  Lines      118559   118561       +2     
  Branches    37995    37999       +4     
==========================================
- Hits        18169    18168       -1     
  Misses      79657    79657              
- Partials    20733    20736       +3     
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 15.32% <40.00%> (-0.01%) ⬇️ Carriedforward from b6eee13

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

felixf4xu and others added 3 commits November 30, 2023 08:21
Signed-off-by: CW01\uig08771 <[email protected]>
Signed-off-by: CW01\uig08771 <[email protected]>
Co-authored-by: M. Fatih Cırıt <[email protected]>
@wep21
Copy link
Contributor

wep21 commented Nov 30, 2023

Internet access is disable during build process in github actions due to this PR.

@wep21
Copy link
Contributor

wep21 commented Dec 5, 2023

The package was removed by this PR.

@wep21 wep21 closed this Dec 5, 2023
@felixf4xu felixf4xu deleted the cmake-trtexec branch December 5, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmake error of TRTEXEC_DEFAULT_BIN string value
3 participants