Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake error of TRTEXEC_DEFAULT_BIN string value #5453

Closed
3 tasks done
felixf4xu opened this issue Nov 1, 2023 · 4 comments
Closed
3 tasks done

cmake error of TRTEXEC_DEFAULT_BIN string value #5453

felixf4xu opened this issue Nov 1, 2023 · 4 comments
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned)

Comments

@felixf4xu
Copy link
Contributor

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

In cmake file of autoware.universe/common/trtexec_vendor/CMakeLists.txt, this line has a bug:

set(TRTEXEC_DEFAULT_BIN /usr/src/tensorrt/bin/trtexec)
if(NOT EXISTS TRTEXEC_DEFAULT_BIN)

it should be:

if(NOT EXISTS ${TRTEXEC_DEFAULT_BIN})

please notice the ${}

Expected behavior

cmake can detect trtexec bin file

Actual behavior

cmake failes to detect trtexec even if the file exists

Steps to reproduce

run cmake of colcon for this package

Versions

Ubuntu 22
humble
autoware main branch

Possible causes

No response

Additional context

No response

@xmfcx xmfcx added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) Component: perception labels Nov 1, 2023
@xmfcx
Copy link
Contributor

xmfcx commented Nov 1, 2023

Thank you for bringing this to our attention.

You're right; it's a typo in the CMakeLists.txt file which can cause the described issue.

Would you be interested in contributing a small PR to fix this?
If not, we'll address it promptly. We appreciate your help in improving Autoware.

@isouf
Copy link
Contributor

isouf commented Nov 22, 2023

I am facing the same issue when trying to build the workspace (inside Docker) of the latest autoware main branch. I also confirm that the solution proposed by @felixf4xu resolves problem 👍 . Would be good to check and merge the PR #5464 created by @felixf4xu.

Copy link

stale bot commented Jan 22, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jan 22, 2024
@amadeuszsz
Copy link
Contributor

Closing with reference to #5749 and #5464 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants