fix(lane_change): fix terminal stop distance #5392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosuke55
requested review from
rej55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
the
component:planning
kosuke55
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5392 +/- ##
=======================================
Coverage 14.80% 14.81%
=======================================
Files 1662 1662
Lines 115421 115428 +7
Branches 35635 35642 +7
=======================================
+ Hits 17092 17096 +4
+ Misses 79085 79084 -1
- Partials 19244 19248 +4
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: kosuke55 <[email protected]>
kosuke55
force-pushed
the
fix/lc_terminal_stop_distance
branch
from
2c5d290 to
4ca48aa
Compare
Signed-off-by: kosuke55 <[email protected]>
kosuke55
force-pushed
the
fix/lc_terminal_stop_distance
branch
from
15cdf37 to
d804f4d
Compare
rej55
approved these changes
Oct 24, 2023
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 25, 2023
* fix(lane_change): fix terminal stop distance Signed-off-by: kosuke55 <[email protected]> * make current lanes include path front id Signed-off-by: kosuke55 <[email protected]> * fixup! make current lanes include path front id --------- Signed-off-by: kosuke55 <[email protected]>
7 tasks
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 25, 2023
* fix(lane_change): fix terminal stop distance Signed-off-by: kosuke55 <[email protected]> * make current lanes include path front id Signed-off-by: kosuke55 <[email protected]> * fixup! make current lanes include path front id --------- Signed-off-by: kosuke55 <[email protected]>
7 tasks
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 31, 2023
fix(lane_change): fix terminal stop distance (autowarefoundation#5392)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix terminal stop distance
(extend previous current lanes)
Related links
tier4 internal
Tests performed
2023/10/24 https://evaluation.tier4.jp/evaluation/reports/fedf22ba-e9e5-5eb3-86ae-6a607bc468d2/?project_id=prd_jt
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.