Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix lane extension in getCurrentLanesFromPath #5415

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Oct 26, 2023

Description

fix infinity extension in loop lanes like
image

this bug is caused by #5392
If there is no first point of path point behind current_lanes, it will loop forever.
This PR only extends if they exist in the same sequence. Furthermore, the extension is restricted to only within the root_lanes.

Related links

#5392

Tests performed

psim

the failed scenario in local

evaluator_description: fix/getCurrentLanesFromPath
2023/10/26 https://evaluation.tier4.jp/evaluation/reports/bb494913-907e-5aa9-a638-d11a4c087f32/?project_id=prd_jt

https://evaluation.tier4.jp/evaluation/reports/61f7793a-366d-5589-80e4-c817ed75c233/?project_id=prd_jt

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 26, 2023
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 26, 2023
@kosuke55 kosuke55 force-pushed the fix/getCurrentLanesFromPath branch from 87a7919 to 5bde001 Compare October 26, 2023 02:36
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (82a6c0c) 14.75% compared to head (c93a2d0) 14.75%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5415   +/-   ##
=======================================
  Coverage   14.75%   14.75%           
=======================================
  Files        1661     1661           
  Lines      115525   115529    +4     
  Branches    35670    35676    +6     
=======================================
+ Hits        17050    17051    +1     
+ Misses      79231    79222    -9     
- Partials    19244    19256   +12     
Flag Coverage Δ *Carryforward flag
differential 12.34% <0.00%> (?)
total 14.75% <ø> (-0.01%) ⬇️ Carriedforward from 5bde001

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
planning/behavior_path_planner/src/utils/utils.cpp 13.93% <0.00%> (+0.19%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: kosuke55 <[email protected]>
@kosuke55 kosuke55 merged commit fdd671f into main Oct 26, 2023
@kosuke55 kosuke55 deleted the fix/getCurrentLanesFromPath branch October 26, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants