-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(planner_manager): limit iteration number by parameter #5352
Merged
satoshi-ota
merged 1 commit into
autowarefoundation:main
from
satoshi-ota:feat/limit-iteration
Oct 19, 2023
Merged
feat(planner_manager): limit iteration number by parameter #5352
satoshi-ota
merged 1 commit into
autowarefoundation:main
from
satoshi-ota:feat/limit-iteration
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoshi-ota
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
October 19, 2023 02:27
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Oct 19, 2023
Merged
4 tasks
rej55
reviewed
Oct 19, 2023
planning/behavior_path_planner/config/behavior_path_planner.param.yaml
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/include/behavior_path_planner/parameters.hpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/include/behavior_path_planner/planner_manager.hpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/include/behavior_path_planner/planner_manager.hpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/src/behavior_path_planner_node.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/src/behavior_path_planner_node.cpp
Outdated
Show resolved
Hide resolved
satoshi-ota
force-pushed
the
feat/limit-iteration
branch
from
October 19, 2023 02:48
aa9464c
to
6ca12ff
Compare
satoshi-ota
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Oct 19, 2023
rej55
reviewed
Oct 19, 2023
Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
force-pushed
the
feat/limit-iteration
branch
from
October 19, 2023 02:51
6ca12ff
to
1c843ac
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5352 +/- ##
=======================================
Coverage 14.76% 14.77%
=======================================
Files 1662 1662
Lines 115310 115389 +79
Branches 35553 35617 +64
=======================================
+ Hits 17031 17044 +13
- Misses 79056 79119 +63
- Partials 19223 19226 +3
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
rej55
approved these changes
Oct 19, 2023
satoshi-ota
added a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Oct 20, 2023
…oundation#5352) Signed-off-by: satoshi-ota <[email protected]>
Closed
4 tasks
4 tasks
satoshi-ota
added a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Nov 22, 2023
…oundation#5352) Signed-off-by: satoshi-ota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at aa9464c
This pull request adds a new parameter
max_itration_num
to the behavior path planner node and its components. The parameter controls the maximum number of iterations for the planner manager to run the behavior modules and select the best output. This improves the performance and stability of the path planning process.Please review following PR at first:
autowarefoundation/autoware_launch#645
Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.