Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planner_manager): limit iteration number by parameter #5352

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Oct 19, 2023

Description

🤖 Generated by Copilot at aa9464c

This pull request adds a new parameter max_itration_num to the behavior path planner node and its components. The parameter controls the maximum number of iterations for the planner manager to run the behavior modules and select the best output. This improves the performance and stability of the path planning process.

Please review following PR at first:
autowarefoundation/autoware_launch#645

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 19, 2023
@satoshi-ota satoshi-ota requested a review from rej55 October 19, 2023 02:52
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 234 lines in your changes are missing coverage. Please review.

Comparison is base (2ad1d81) 14.76% compared to head (1c843ac) 14.77%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5352   +/-   ##
=======================================
  Coverage   14.76%   14.77%           
=======================================
  Files        1662     1662           
  Lines      115310   115389   +79     
  Branches    35553    35617   +64     
=======================================
+ Hits        17031    17044   +13     
- Misses      79056    79119   +63     
- Partials    19223    19226    +3     
Flag Coverage Δ *Carryforward flag
differential 12.30% <6.40%> (?)
total 14.78% <ø> (+0.01%) ⬆️ Carriedforward from 2ad1d81

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...anner/include/behavior_path_planner/parameters.hpp 57.14% <ø> (ø)
.../include/behavior_path_planner/planner_manager.hpp 19.54% <ø> (ø)
...avior_path_planner/src/utils/goal_planner/util.cpp 5.88% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 27.40% <0.00%> (-0.06%) ⬇️
...ning/behavior_path_planner/src/planner_manager.cpp 17.32% <25.00%> (+0.03%) ⬆️
.../scene_module/goal_planner/goal_planner_module.hpp 24.56% <32.55%> (+24.56%) ⬆️
.../scene_module/goal_planner/goal_planner_module.cpp 5.17% <0.00%> (-0.44%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 0d0a22c into autowarefoundation:main Oct 19, 2023
23 of 26 checks passed
@satoshi-ota satoshi-ota deleted the feat/limit-iteration branch October 19, 2023 07:17
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Oct 20, 2023
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants