Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): ignore occlusion beyond high curvature point #5219

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Oct 4, 2023

Description

Related links

https://tier4.atlassian.net/browse/RT1-3949

launcher PR: autowarefoundation/autoware_launch#619

Tests performed

Notes for reviewers

Interface changes

none.

Effects on system behavior

none.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Oct 4, 2023
@soblin soblin force-pushed the feat/intersection/crop-curve-occlusion-attention-area branch from cc2d99a to 5e0e961 Compare October 4, 2023 05:12
@github-actions github-actions bot removed the type:documentation Creating or refining documentation. (auto-assigned) label Oct 4, 2023
@soblin soblin force-pushed the feat/intersection/crop-curve-occlusion-attention-area branch from 5e0e961 to 13148ce Compare October 4, 2023 05:18
@soblin soblin marked this pull request as ready for review October 4, 2023 05:28
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (6155f1f) 14.79% compared to head (13148ce) 14.79%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5219      +/-   ##
==========================================
- Coverage   14.79%   14.79%   -0.01%     
==========================================
  Files        1648     1648              
  Lines      113918   113944      +26     
  Branches    35074    35095      +21     
==========================================
- Hits        16859    16858       -1     
- Misses      78135    78159      +24     
- Partials    18924    18927       +3     
Flag Coverage Δ *Carryforward flag
differential 6.39% <0.00%> (?)
total 14.81% <ø> (+0.01%) ⬆️ Carriedforward from 8a0ff1c

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)
...ior_velocity_intersection_module/src/util_type.hpp 0.00% <ø> (ø)
...avior_velocity_intersection_module/src/manager.cpp 16.45% <0.00%> (-0.15%) ⬇️
...ity_intersection_module/src/scene_intersection.cpp 0.00% <0.00%> (ø)
...behavior_velocity_intersection_module/src/util.cpp 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin closed this Oct 4, 2023
@soblin soblin deleted the feat/intersection/crop-curve-occlusion-attention-area branch November 10, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant