-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change): expand target lanes for object filtering #5167
feat(lane_change): expand target lanes for object filtering #5167
Conversation
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5167 +/- ##
==========================================
- Coverage 14.85% 14.83% -0.03%
==========================================
Files 1627 1627
Lines 112656 112912 +256
Branches 34806 35004 +198
==========================================
+ Hits 16739 16749 +10
- Misses 77156 77390 +234
- Partials 18761 18773 +12
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
…foundation#5167) * feat(lane_change): expand target lanes for object filtering Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * use expanded target lanes in collision check Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
…foundation#5167) * feat(lane_change): expand target lanes for object filtering Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * use expanded target lanes in collision check Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
…foundation#5167) * feat(lane_change): expand target lanes for object filtering Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * use expanded target lanes in collision check Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
…foundation#5167) * feat(lane_change): expand target lanes for object filtering Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * use expanded target lanes in collision check Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
…foundation#5167) * feat(lane_change): expand target lanes for object filtering Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * use expanded target lanes in collision check Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Description
Add lane expansion parameters and logic for object filtering in lane change module. This improves safety check by allowing user to determine if they want to consider slightly out of lane object as target.
Note:
Purple cube: other lane object
Aqua cube: target lane object
Yellow cube: current lane object
Before PR
After PR
Left Expansion with additional 1 m
Left Expansion with additional 10 m
Right Expansion
Related links
autowarefoundation/autoware_launch#601
Tests performed
Place target objects via PSIM
Notes for reviewers
None
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.