Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): expand target lanes for object filtering #5167

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Sep 28, 2023

Description

Add lane expansion parameters and logic for object filtering in lane change module. This improves safety check by allowing user to determine if they want to consider slightly out of lane object as target.

Note:
Purple cube: other lane object
Aqua cube: target lane object
Yellow cube: current lane object

Before PR

Screenshot from 2023-09-28 12-25-45

After PR

Left Expansion with additional 1 m

Screenshot from 2023-09-28 12-29-05

Left Expansion with additional 10 m

Screenshot from 2023-09-28 12-30-38

Right Expansion

Screenshot from 2023-09-28 12-38-00

Related links

autowarefoundation/autoware_launch#601

Tests performed

Place target objects via PSIM

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 28, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (c552c3d) 14.85% compared to head (61b2929) 14.83%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5167      +/-   ##
==========================================
- Coverage   14.85%   14.83%   -0.03%     
==========================================
  Files        1627     1627              
  Lines      112656   112912     +256     
  Branches    34806    35004     +198     
==========================================
+ Hits        16739    16749      +10     
- Misses      77156    77390     +234     
- Partials    18761    18773      +12     
Flag Coverage Δ *Carryforward flag
differential 12.47% <0.00%> (?)
total 14.86% <ø> (+<0.01%) ⬆️ Carriedforward from 77c3b83

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...nner/utils/lane_change/lane_change_module_data.hpp 0.00% <ø> (ø)
...h_planner/src/scene_module/lane_change/manager.cpp 5.00% <0.00%> (-0.11%) ⬇️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.44% <0.00%> (-0.01%) ⬇️
...th_planner/src/scene_module/lane_change/normal.cpp 4.48% <0.00%> (-0.02%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit c99c6b2 into autowarefoundation:main Oct 2, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the feat-lc-object-filter-expanded-lanes branch October 2, 2023 01:55
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Oct 2, 2023
…foundation#5167)

* feat(lane_change): expand target lanes for object filtering

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* use expanded target lanes in collision check

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Oct 3, 2023
…foundation#5167)

* feat(lane_change): expand target lanes for object filtering

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* use expanded target lanes in collision check

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Oct 5, 2023
…foundation#5167)

* feat(lane_change): expand target lanes for object filtering

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* use expanded target lanes in collision check

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
t4-x2 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 5, 2023
…foundation#5167)

* feat(lane_change): expand target lanes for object filtering

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* use expanded target lanes in collision check

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Oct 6, 2023
…foundation#5167)

* feat(lane_change): expand target lanes for object filtering

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* use expanded target lanes in collision check

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants