-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intersection): use planned velocity from upstream modules #5156
Merged
soblin
merged 4 commits into
autowarefoundation:main
from
tier4:feat/intersection/use-upstream-velocity-planning
Sep 28, 2023
Merged
feat(intersection): use planned velocity from upstream modules #5156
soblin
merged 4 commits into
autowarefoundation:main
from
tier4:feat/intersection/use-upstream-velocity-planning
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Sep 27, 2023
soblin
changed the title
Feat/intersection/use upstream velocity planning
feat(intersection): use planned velocity from upstream modules
Sep 27, 2023
7 tasks
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
soblin
force-pushed
the
feat/intersection/use-upstream-velocity-planning
branch
from
September 27, 2023 10:17
60d7aeb
to
ebed0b9
Compare
soblin
requested review from
shmpwk,
takayuki5168 and
tkimura4
as code owners
September 27, 2023 14:07
soblin
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Sep 27, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5156 +/- ##
==========================================
- Coverage 14.86% 14.86% -0.01%
==========================================
Files 1627 1627
Lines 112571 112582 +11
Branches 34766 34776 +10
==========================================
Hits 16739 16739
- Misses 77076 77083 +7
- Partials 18756 18760 +4
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Mamoru Sobue <[email protected]>
takayuki5168
approved these changes
Sep 28, 2023
soblin
restored the
feat/intersection/use-upstream-velocity-planning
branch
September 28, 2023 04:24
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 28, 2023
…arefoundation#5156) Signed-off-by: Mamoru Sobue <[email protected]>
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 28, 2023
…arefoundation#5156) Signed-off-by: Mamoru Sobue <[email protected]>
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 30, 2023
feat(intersection): use planned velocity from upstream modules (autowarefoundation#5156)
4 tasks
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 8, 2023
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 8, 2023
…arefoundation#5156) Signed-off-by: Mamoru Sobue <[email protected]>
This was referenced Oct 11, 2023
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 11, 2023
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 11, 2023
…arefoundation#5156) Signed-off-by: Mamoru Sobue <[email protected]>
soblin
added a commit
to soblin/autoware.universe
that referenced
this pull request
Nov 18, 2023
…arefoundation#5156) Signed-off-by: Mamoru Sobue <[email protected]>
kyoichi-sugahara
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 29, 2023
…arefoundation#5156) Signed-off-by: Mamoru Sobue <[email protected]>
4 tasks
satoshi-ota
pushed a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Jan 14, 2024
…arefoundation#5156) Signed-off-by: Mamoru Sobue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a flag to use the planned velocity profile from the upstream modules, especially for stop line.
Related links
https://tier4.atlassian.net/browse/RT1-3624
https://tier4.atlassian.net/browse/RT1-136
launcher PR: autowarefoundation/autoware_launch#597
Tests performed
evaluator: https://evaluation.tier4.jp/evaluation/reports/eb4df583-e8d5-5def-92f1-b163d12ddba5?project_id=prd_jt
Simple test case
In the attached video ego vehicle takes 8 seconds to arrive at the walkway virtual wall, and the
collision_detection.collision_start_margin_time = 4.0
[s] and ego stops at the walkway for 1[s], so the NPC travelling at 3[m/s] from the position which is (8 + 4 + 1) x 3 = 39m before the collision point is expected to be treated assafe
by the intersection module but actually collides while ego is stopping at the walkway.Before this PR, the collision happens as expected
absence_tl-2023-09-28_00.43.10.mp4
After this PR the intersection module inserts stop line
absence_tl-2023-09-28_00.45.24.mp4
Notes for reviewers
Interface changes
none.
Effects on system behavior
none.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.