Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): use planned velocity from upstream modules #5156

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Sep 27, 2023

Description

Add a flag to use the planned velocity profile from the upstream modules, especially for stop line.

Related links

https://tier4.atlassian.net/browse/RT1-3624
https://tier4.atlassian.net/browse/RT1-136

launcher PR: autowarefoundation/autoware_launch#597

Tests performed

evaluator: https://evaluation.tier4.jp/evaluation/reports/eb4df583-e8d5-5def-92f1-b163d12ddba5?project_id=prd_jt

Simple test case

In the attached video ego vehicle takes 8 seconds to arrive at the walkway virtual wall, and the collision_detection.collision_start_margin_time = 4.0[s] and ego stops at the walkway for 1[s], so the NPC travelling at 3[m/s] from the position which is (8 + 4 + 1) x 3 = 39m before the collision point is expected to be treated as safe by the intersection module but actually collides while ego is stopping at the walkway.

Before this PR, the collision happens as expected

absence_tl-2023-09-28_00.43.10.mp4

After this PR the intersection module inserts stop line

absence_tl-2023-09-28_00.45.24.mp4

Notes for reviewers

Interface changes

none.

Effects on system behavior

none.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 27, 2023
@soblin soblin changed the title Feat/intersection/use upstream velocity planning feat(intersection): use planned velocity from upstream modules Sep 27, 2023
@soblin soblin force-pushed the feat/intersection/use-upstream-velocity-planning branch from 60d7aeb to ebed0b9 Compare September 27, 2023 10:17
@soblin soblin marked this pull request as ready for review September 27, 2023 14:07
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (0cd4f62) 14.86% compared to head (fa69800) 14.86%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5156      +/-   ##
==========================================
- Coverage   14.86%   14.86%   -0.01%     
==========================================
  Files        1627     1627              
  Lines      112571   112582      +11     
  Branches    34766    34776      +10     
==========================================
  Hits        16739    16739              
- Misses      77076    77083       +7     
- Partials    18756    18760       +4     
Flag Coverage Δ *Carryforward flag
differential 6.77% <0.00%> (?)
total 14.87% <ø> (+<0.01%) ⬆️ Carriedforward from ac42363

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)
...avior_velocity_intersection_module/src/manager.cpp 17.25% <0.00%> (-0.32%) ⬇️
...ity_intersection_module/src/scene_intersection.cpp 0.00% <0.00%> (ø)
...behavior_velocity_intersection_module/src/util.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 17984b4 into autowarefoundation:main Sep 28, 2023
@soblin soblin deleted the feat/intersection/use-upstream-velocity-planning branch September 28, 2023 04:24
@soblin soblin restored the feat/intersection/use-upstream-velocity-planning branch September 28, 2023 04:24
@soblin soblin deleted the feat/intersection/use-upstream-velocity-planning branch September 28, 2023 04:24
soblin added a commit to tier4/autoware.universe that referenced this pull request Sep 28, 2023
soblin added a commit to tier4/autoware.universe that referenced this pull request Sep 28, 2023
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Sep 30, 2023
feat(intersection): use planned velocity from upstream modules (autowarefoundation#5156)
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Oct 8, 2023
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 8, 2023
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Oct 11, 2023
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 11, 2023
soblin added a commit to soblin/autoware.universe that referenced this pull request Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants