fix(autoware_behavior_velocity_planner): fix some clang-tidy errors

Signed-off-by: Esteve Fernandez <[email protected]>
autowarefoundation · Apr 12, 2024 · e3c48cc · e3c48cc
1 parent 173ed48
commit e3c48cc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/planning/behavior_velocity_planner/src/node.cpp b/planning/behavior_velocity_planner/src/node.cpp
@@ -54,6 +54,8 @@ rclcpp::SubscriptionOptions createSubscriptionOptions(rclcpp::Node * node_ptr)
 
 namespace autoware::behavior_velocity_planner
 {
+using ::behavior_velocity_planner::TrafficSignalStamped;
+
 namespace
 {
 

diff --git a/planning/behavior_velocity_planner/src/node.hpp b/planning/behavior_velocity_planner/src/node.hpp
@@ -50,7 +50,6 @@ using autoware_auto_mapping_msgs::msg::HADMapBin;
 using autoware_behavior_velocity_planner::srv::LoadPlugin;
 using autoware_behavior_velocity_planner::srv::UnloadPlugin;
 using ::behavior_velocity_planner::PlannerData;
-using ::behavior_velocity_planner::TrafficSignalStamped;
 using tier4_planning_msgs::msg::VelocityLimit;
 
 class BehaviorVelocityPlannerNode : public rclcpp::Node

diff --git a/planning/behavior_velocity_planner/src/planner_manager.hpp b/planning/behavior_velocity_planner/src/planner_manager.hpp
@@ -52,7 +52,7 @@ class BehaviorVelocityPlannerManager
     const std::shared_ptr<const PlannerData> & planner_data,
     const autoware_auto_planning_msgs::msg::PathWithLaneId & input_path_msg);
 
-  diagnostic_msgs::msg::DiagnosticStatus getStopReasonDiag() const;
+  [[nodiscard]] diagnostic_msgs::msg::DiagnosticStatus getStopReasonDiag() const;
 
 private:
   diagnostic_msgs::msg::DiagnosticStatus stop_reason_diag_;
-Original file line number
+Diff line change
@@ Expand Up @@
     namespace autoware::behavior_velocity_planner
     {
+    using ::behavior_velocity_planner::TrafficSignalStamped;
     namespace
     {
@@ Expand Down @@