fix(autoware_perception_rviz_plugin): fix duplicateBranch warnings

Signed-off-by: Ryuta Kambe <[email protected]>
autowarefoundation · Jun 26, 2024 · 7dcf07e · 7dcf07e
1 parent b67a6c3
commit 7dcf07e
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/common/autoware_perception_rviz_plugin/src/object_detection/object_polygon_detail.cpp b/common/autoware_perception_rviz_plugin/src/object_detection/object_polygon_detail.cpp
@@ -526,10 +526,7 @@ visualization_msgs::msg::Marker::SharedPtr get_shape_marker_ptr(
       marker_ptr->scale = shape_msg.dimensions;
       marker_ptr->color.a = 0.75f;
     }
-  } else if (shape_msg.type == Shape::POLYGON) {
-    marker_ptr->type = visualization_msgs::msg::Marker::LINE_LIST;
-    calc_polygon_line_list(shape_msg, marker_ptr->points);
-  } else {
+  } else { // including shape_msg.type == Shape::POLYGON
     marker_ptr->type = visualization_msgs::msg::Marker::LINE_LIST;
     calc_polygon_line_list(shape_msg, marker_ptr->points);
   }
@@ -562,10 +559,7 @@ visualization_msgs::msg::Marker::SharedPtr get_2d_shape_marker_ptr(
   } else if (shape_msg.type == Shape::CYLINDER) {
     marker_ptr->type = visualization_msgs::msg::Marker::LINE_LIST;
     calc_2d_cylinder_bottom_line_list(shape_msg, marker_ptr->points);
-  } else if (shape_msg.type == Shape::POLYGON) {
-    marker_ptr->type = visualization_msgs::msg::Marker::LINE_LIST;
-    calc_2d_polygon_bottom_line_list(shape_msg, marker_ptr->points);
-  } else {
+  } else { // including shape_msg.type == Shape::POLYGON
     marker_ptr->type = visualization_msgs::msg::Marker::LINE_LIST;
     calc_2d_polygon_bottom_line_list(shape_msg, marker_ptr->points);
   }