Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings v2] Homepage and manage identites #4784

Merged

Conversation

IniZio
Copy link
Contributor

@IniZio IniZio commented Oct 2, 2024

Settings v2 features covered:

  • Homepage
  • Manage Identities
    • Phone
    • Username
    • Email
      • Change primary email
  • Manage MFA
    • Phone (list)
    • Email (list)
    • TOTP (list)
    • Password (list + add)
    • Trusted devices
  • Other security settings
    • Biometric
    • Password
    • Signed-in devices
  • Schedule account deletion

ref DEV-2093
ref DEV-1840
ref DEV-2049
ref DEV-1928
ref DEV-1927
ref DEV-1973
ref DEV-1866
ref DEV-1926
ref DEV-1870
ref DEV-1923
ref DEV-1868
ref DEV-1929
ref DEV-1925
ref DEV-1922
ref DEV-1867
ref DEV-1963
ref DEV-1966
ref DEV-1960
ref DEV-1924
ref DEV-1921
ref DEV-1995
ref DEV-1994
ref DEV-1920
ref DEV-2043
ref DEV-1993
ref DEV-1992
ref DEV-2041
ref DEV-1969
ref DEV-1970
ref DEV-2009
ref DEV-2042
ref DEV-2045
ref DEV-2044
ref DEV-2015

@IniZio IniZio force-pushed the feat-authuiv2-settings-squashed branch from 5f622e0 to 1e8fc72 Compare October 2, 2024 09:56
@IniZio IniZio changed the title Settings V2 with homepage and manage identites Settings v2 with homepage and manage identites Oct 2, 2024
@IniZio IniZio changed the title Settings v2 with homepage and manage identites [Settings v2] Homepage and manage identites Oct 2, 2024
@IniZio IniZio mentioned this pull request Oct 2, 2024
1 task
@IniZio IniZio force-pushed the feat-authuiv2-settings-squashed branch 2 times, most recently from 0d53d5e to b883619 Compare October 3, 2024 07:41
.make-lint-translation-keys-expect Outdated Show resolved Hide resolved
authui/src/authflowv2/settingsDialog.ts Outdated Show resolved Hide resolved
authui/src/authflowv2/components/otp-input.css Outdated Show resolved Hide resolved
authui/src/authflowv2/base.css Outdated Show resolved Hide resolved
resources/authgear/templates/en/translation.json Outdated Show resolved Hide resolved
resources/authgear/templates/en/translation.json Outdated Show resolved Hide resolved
resources/authgear/templates/en/translation.json Outdated Show resolved Hide resolved
resources/authgear/templates/en/translation.json Outdated Show resolved Hide resolved
authui/src/authflowv2.ts Outdated Show resolved Hide resolved
pkg/auth/handler/webapp/authflowv2/routes.go Outdated Show resolved Hide resolved
@IniZio IniZio force-pushed the feat-authuiv2-settings-squashed branch 7 times, most recently from 29c2da2 to ec2ffb1 Compare October 4, 2024 10:02
@IniZio
Copy link
Contributor Author

IniZio commented Oct 4, 2024

@louischan-oursky Updated

@IniZio IniZio force-pushed the feat-authuiv2-settings-squashed branch from ec2ffb1 to 0eb766f Compare October 7, 2024 03:23
@@ -110,7 +110,7 @@
"copied-button-label": "Copied",
"get-new-recovery-codes-button-label": "Get new codes",
"download-button-label": "Download",
"disconnect-button-label": "Disconnect",
"remove-biometric-button-label": "Disconnect",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not change v1 translation key.

Copy link
Contributor Author

@IniZio IniZio Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit was actually fixed up last week, just tried to rebase and force push again

@IniZio IniZio force-pushed the feat-authuiv2-settings-squashed branch 2 times, most recently from 0b60f9f to 1aca140 Compare October 7, 2024 07:06
@louischan-oursky
Copy link
Collaborator

@IniZio Still failed.

@IniZio IniZio force-pushed the feat-authuiv2-settings-squashed branch from 1aca140 to 624ad32 Compare October 7, 2024 07:31
@louischan-oursky louischan-oursky merged commit 71f1f62 into authgear:main Oct 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants