Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings v2] Manage MFA - Without Recovery Code #4792

Merged
merged 31 commits into from
Oct 14, 2024
Merged

[Settings v2] Manage MFA - Without Recovery Code #4792

merged 31 commits into from
Oct 14, 2024

Conversation

IniZio
Copy link
Contributor

@IniZio IniZio commented Oct 3, 2024 •
edited
Loading

ref DEV-1964
ref DEV-1967
ref DEV-1971
ref DEV-1961

CI: IniZio#1

Dependencies:

Demo:

TOTP

Screen.Recording.2024-10-03.at.4.31.49.PM.mov

Email

Screen.Recording.2024-10-03.at.4.59.18.PM.mov

OTP

Screen.Recording.2024-10-03.at.4.59.34.PM.mov

Password

Screen.Recording.2024-10-03.at.5.36.44.PM.mov

Change Password

Screen.Recording.2024-10-03.at.6.16.28.PM.mov

@IniZio IniZio changed the title [Settings v2] Delete MFA - TOTP, OTP, Password [Settings v2] Delete/Edit MFA - TOTP, OTP, Password Oct 3, 2024
@IniZio IniZio force-pushed the dev-1951-remove-authenticator branch from 43aab03 to 289d880 Compare October 4, 2024 03:30
@IniZio IniZio changed the title [Settings v2] Delete/Edit MFA - TOTP, OTP, Password [Settings v2] Manage MFA Oct 7, 2024
This was referenced Oct 7, 2024
Closed
Closed
@IniZio IniZio force-pushed the dev-1951-remove-authenticator branch 3 times, most recently from 0144953 to b4b6475 Compare October 7, 2024 05:17
@louischan-oursky louischan-oursky self-requested a review October 7, 2024 07:50
@louischan-oursky louischan-oursky self-assigned this Oct 7, 2024
@louischan-oursky
Copy link
Collaborator

Please rebase.

@IniZio IniZio force-pushed the dev-1951-remove-authenticator branch from bb55c0b to 802f603 Compare October 7, 2024 07:56
@IniZio IniZio force-pushed the dev-1951-remove-authenticator branch from af7ed96 to 80ffad4 Compare October 7, 2024 08:12
@louischan-oursky
Copy link
Collaborator

lint failed.

@louischan-oursky louischan-oursky self-requested a review October 7, 2024 10:28
louischan-oursky
louischan-oursky requested changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@louischan-oursky louischan-oursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove 2FA authenticator button has no response.
  2. Add more than 1 2FA authenticator should not (re-generate recovery code and show).
  3. With authentication.recovery_code.list_enabled=true, no recovery code related settings is shown.

@IniZio IniZio force-pushed the dev-1951-remove-authenticator branch from 11b4941 to ad62a74 Compare October 7, 2024 11:16
@louischan-oursky louischan-oursky changed the title [Settings v2] Manage MFA [BLOCKED] [Settings v2] Manage MFA Oct 8, 2024
@IniZio IniZio changed the title [BLOCKED] [Settings v2] Manage MFA [WIP] [Settings v2] Manage MFA Oct 8, 2024
@IniZio
Copy link
Contributor Author

IniZio commented Oct 9, 2024 •
edited
Loading

@louischan-oursky Fixed 1 and 2, but for 3 design is actually missing for regenerating recovery code.

Asking designer for layout of regenerate action, maybe I handle it in DEV-2006 instead?

@IniZio IniZio force-pushed the dev-1951-remove-authenticator branch 3 times, most recently from 699ae2e to 15f0418 Compare October 9, 2024 03:44
@IniZio IniZio changed the title [WIP] [Settings v2] Manage MFA [Settings v2] Manage MFA - Without Recovery Code Oct 10, 2024
@IniZio IniZio force-pushed the dev-1951-remove-authenticator branch from 15f0418 to e292f74 Compare October 10, 2024 02:55
This was referenced Oct 10, 2024
Closed
Merged
@IniZio IniZio force-pushed the dev-1951-remove-authenticator branch from e292f74 to 3f03982 Compare October 10, 2024 04:57
IniZio added 26 commits October 10, 2024 17:08
@IniZio
Add finish create totp in account management
ae43cbc
@IniZio
Add settings v2 create totp page
92c569a
@IniZio
Add settings v2 enter totp page
ff72c68
@IniZio
Add settings v2 view recovery code page
f7c85d9
@IniZio
Generate translations
3f42fb0
@IniZio
Fix transaction not started error when update password in settings v2
9ecfa10
@IniZio
Add start create oobotp in account management
01499ff
@IniZio
Add resume create oobotp and resend oobotp in account management
5c90b35
@IniZio
Add finish create oobotp in account management
d58d44a
@IniZio
Add settings v2 create oob otp page
f539cb5
@IniZio
Add settings v2 enter oob otp page
75b416f
@IniZio
Generate translations
d095fc3
@IniZio
Add remove totp in account management
26aab57
@IniZio
Add remove totp dialog for settings v2
2aa5ca2
@IniZio
Generate translations
36f19d5
@IniZio
Add remove otp in account management
8dad035
@IniZio
Add remove totp dialog for settings v2
77a0b2b
@IniZio
Generate translations
cf402cf
@IniZio
Add remove secondary password in account management
e5db7ed
@IniZio
Add remove secondary password action for settings v2
61c5465
@IniZio
Add change secondary password action for settings v2
db4653f
@IniZio
Generate translations
54923d5
@IniZio
Remove back action in settings v2 mfa recover code page
92bbdba
@IniZio
Update wire_gen
634ec0f
@IniZio
Resolve lint errors
bc584cd
@IniZio
Skip 2fa recovery code step if disabled or exists in settings v2
7bca2be
@IniZio IniZio force-pushed the dev-1951-remove-authenticator branch from 3f03982 to 7bca2be Compare October 10, 2024 09:08
@louischan-oursky louischan-oursky self-requested a review October 14, 2024 03:00
@louischan-oursky louischan-oursky merged commit 91eb433 into authgear:main Oct 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louischan-oursky louischan-oursky louischan-oursky approved these changes

Assignees

@louischan-oursky louischan-oursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IniZio @louischan-oursky @cychiuae