Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings v2] Edit profile - Handle readonly in name settings #4795

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[Settings v2] Edit profile - Handle readonly in name settings #4795

merged 2 commits into from
Oct 15, 2024

Conversation

IniZio
Copy link
Contributor

@IniZio IniZio commented Oct 4, 2024 •
edited
Loading

ref DEV-1939

Dependencies:

Demo:

Screen.Recording.2024-10-04.at.11.14.05.AM.mp4

@IniZio IniZio changed the title Implement identity and authenticator backend actions for account mana… [Settings v2] Edit profile - Handle readonly in name settings Oct 4, 2024
@louischan-oursky
Copy link
Collaborator

Please rebase.

@IniZio IniZio force-pushed the dev-1939-profile-readonly-field branch 2 times, most recently from fa660a7 to bfb8c63 Compare October 7, 2024 09:29
@louischan-oursky louischan-oursky self-requested a review October 7, 2024 10:35
@louischan-oursky louischan-oursky self-assigned this Oct 7, 2024
louischan-oursky
louischan-oursky requested changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@louischan-oursky louischan-oursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The disabled state of a control is too subtle. Common disabled controls usually have a gray background color.
  2. Maybe add an italic text under a readonly field saying "Not editable".

@louischan-oursky
Copy link
Collaborator

This is pending design update.

@IniZio IniZio changed the title [Settings v2] Edit profile - Handle readonly in name settings [BLOCKED] [Settings v2] Edit profile - Handle readonly in name settings Oct 8, 2024
@IniZio
Copy link
Contributor Author

IniZio commented Oct 14, 2024

Updated style for disabled text input

Screen Shot 2024-10-14 at 11 13 39

@IniZio IniZio changed the title [BLOCKED] [Settings v2] Edit profile - Handle readonly in name settings [Settings v2] Edit profile - Handle readonly in name settings Oct 14, 2024
@louischan-oursky
Copy link
Collaborator

Conflicted.

@IniZio IniZio force-pushed the dev-1939-profile-readonly-field branch from 2ee4335 to 5096489 Compare October 14, 2024 04:39
@louischan-oursky louischan-oursky self-requested a review October 15, 2024 03:15
@louischan-oursky louischan-oursky merged commit 53a0ad9 into authgear:main Oct 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louischan-oursky louischan-oursky louischan-oursky approved these changes

Assignees

@louischan-oursky louischan-oursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IniZio @louischan-oursky