Enable resultset validation of Drill tests #15096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit baddb89.
| List<Object[]> expectedResults = parseResults(currentRowSignature, expectedResultsText); | ||
| try { | ||
| Assert.assertEquals(StringUtils.format("result count: %s", sql), expectedResultsText.size(), results.size()); | ||
| if (!isOrdered(sql)) { |
There was a problem hiding this comment.
shouldn't this be flipped?
There was a problem hiding this comment.
the logic here is kinda like: if the resultset is not ordered - lets order both of them by the same comparator and expect the same (ordered) resultsets after that
There was a problem hiding this comment.
Ah ok. Because there is no guarantee about what order the results will arrive in. can you please add a comment here in the code itself?
There was a problem hiding this comment.
can be done in a follow-up PR.
There was a problem hiding this comment.
I've changed a few more things - and made SqlToRelConverter#isOrdered do the decision here - but these changes become dependendt on #15086 ; I can add it after that
sql/src/test/java/org/apache/druid/sql/calcite/DrillWindowQueryTest.java
Show resolved
Hide resolved
abhishekagarwal87
approved these changes
Oct 10, 2023
pranavbhole
pushed a commit
to pranavbhole/druid
that referenced
this pull request
Oct 12, 2023
- introduces a test_X method for every testcase (995 testcases) - added a resultset parser which reads the expected resultset based on the result schema - loaded a few more datasets - added a testcase to ensure that all files have a corresponding testcase - renamed DecoupledIgnore to NegativeTest - categorized the failing 268 tests
pranavbhole
pushed a commit
to pranavbhole/druid
that referenced
this pull request
Oct 12, 2023
- introduces a test_X method for every testcase (995 testcases) - added a resultset parser which reads the expected resultset based on the result schema - loaded a few more datasets - added a testcase to ensure that all files have a corresponding testcase - renamed DecoupledIgnore to NegativeTest - categorized the failing 268 tests
10 tasks
LakshSingla
pushed a commit
that referenced
this pull request
Oct 13, 2023
- introduces a test_X method for every testcase (995 testcases) - added a resultset parser which reads the expected resultset based on the result schema - loaded a few more datasets - added a testcase to ensure that all files have a corresponding testcase - renamed DecoupledIgnore to NegativeTest - categorized the failing 268 tests
ektravel
pushed a commit
to ektravel/druid
that referenced
this pull request
Oct 16, 2023
- introduces a test_X method for every testcase (995 testcases) - added a resultset parser which reads the expected resultset based on the result schema - loaded a few more datasets - added a testcase to ensure that all files have a corresponding testcase - renamed DecoupledIgnore to NegativeTest - categorized the failing 268 tests
CaseyPan
pushed a commit
to CaseyPan/druid
that referenced
this pull request
Nov 17, 2023
- introduces a test_X method for every testcase (995 testcases) - added a resultset parser which reads the expected resultset based on the result schema - loaded a few more datasets - added a testcase to ensure that all files have a corresponding testcase - renamed DecoupledIgnore to NegativeTest - categorized the failing 268 tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_Xmethod for every testcase (995 testcases)DecoupledIgnoretoNegativeTestcurrent histogram of failures:
This PR has: