Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable resultset validation of Drill tests (#15096) #15146

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Enable resultset validation of Drill tests (#15096) #15146

merged 1 commit into from
Oct 13, 2023

Conversation

pranavbhole
Copy link
Contributor

Backport: #15096

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kgyrtkirk @pranavbhole
Enable resultset validation of Drill tests (apache#15096)
f5619f0 
- introduces a test_X method for every testcase (995 testcases)
- added a resultset parser which reads the expected resultset based on the result schema
- loaded a few more datasets
- added a testcase to ensure that all files have a corresponding testcase
- renamed DecoupledIgnore to NegativeTest
- categorized the failing 268 tests
@pranavbhole pranavbhole marked this pull request as ready for review October 12, 2023 23:54
@pranavbhole pranavbhole changed the title Enable resultset validation of Drill tests (#15096) Backport: Enable resultset validation of Drill tests (#15096) Oct 12, 2023
@pranavbhole pranavbhole changed the title Backport: Enable resultset validation of Drill tests (#15096) Enable resultset validation of Drill tests (#15096) Oct 12, 2023
@clintropolis clintropolis added this to the 28.0 milestone Oct 13, 2023
@LakshSingla LakshSingla removed this from the 28.0 milestone Oct 13, 2023
LakshSingla
LakshSingla approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@LakshSingla LakshSingla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSQ unit tests fail, however, they are unrelated to the PR (and known that they are failing atm). Merging the PR, thanks for the backport.

@LakshSingla LakshSingla merged commit 6dbd556 into apache:28.0.0 Oct 13, 2023
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LakshSingla LakshSingla LakshSingla approved these changes

Assignees
No one assigned
Labels
Area - Querying Backport
Projects
None yet
Milestone
28.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pranavbhole @LakshSingla @clintropolis @kgyrtkirk