Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window Fn backports #15144

Closed
wants to merge 2 commits into from
Closed

Window Fn backports #15144

wants to merge 2 commits into from

Conversation

pranavbhole
Copy link
Contributor

Backports:
#15096
#15086

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kgyrtkirk @pranavbhole
Enable resultset validation of Drill tests (apache#15096)
1af0a5a 
- introduces a test_X method for every testcase (995 testcases)
- added a resultset parser which reads the expected resultset based on the result schema
- loaded a few more datasets
- added a testcase to ensure that all files have a corresponding testcase
- renamed DecoupledIgnore to NegativeTest
- categorized the failing 268 tests
@kgyrtkirk @pranavbhole
Fix non-sqlcompat validation in CalciteWindowQueryTest (apache#15086)
156585b 
* fixes

* check for latest rewrite place

* Revert "check for latest rewrite place"

This reverts commit 5cf1e2c.

* some stuff

(cherry picked from commit ab346d4373ea888eb8ef6115e018e7fb0d27407f)

* update test output

* updates to test ouptuts

* some stuff

* move validator

* cleanup

* fix

* change test slightly

* add apidoc cleanup warnings

* cleanup/etc

* instead of telling the story; add a fail with some reason whats the issue

* lead-lag fix

* add test

* remove unnecessary throw

* druidexception-trial

* Revert "druidexception-trial"

This reverts commit 8fa0664.

* undo changes to no_grouping; add no_grouping2

* add missing assert on resultcount

* rename method; update

* introduce enum/etc

* make resultmatchmode accessible from TestBuilder#expectedResults

* fix dump results to use log

* fix

* handle null correctly

* disable feature type based things for MSQ

* fix varianssqlaggtest

* use eps in other test

* fix intellij error

* add final

* addrss review

* update test/string/etc

* write concat in 3 lines :D
@pranavbhole pranavbhole marked this pull request as ready for review October 12, 2023 23:22
LakshSingla
LakshSingla approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@LakshSingla LakshSingla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Rebase and merge the PR so that the commits show up individually in the history.

@pranavbhole pranavbhole deleted the windowBackports branch October 12, 2023 23:51
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LakshSingla LakshSingla LakshSingla approved these changes

Assignees
No one assigned
Labels
Area - Querying
Projects
None yet
Milestone
28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavbhole @LakshSingla @kgyrtkirk