Feature: Box Storage #192
Merged
Feature: Box Storage #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial (empty) commit * Add boxes field for appl calls * Add golden for box storage appl txn encoding test * Change spacing * Update spacing on transaction feature table * Change goldens for box encoding * Add boxes field to app call tests * Fix box values for app calls * Change test branch and change golden from bytes encoding * Change test branch and repo * Add boxes field for app calls * Add some tricky self referenced app ids * Change boxes field in feetest to empty entry * Add encoding to box args * Move boxes field up to lessen pain * Add test for b64 nulls and invalid utf8s * Add test case for empty box names
* Add some path tests for app box by name * Minor wording * Add case for forward slashes
* integration tests for exercising box features * prefix box name with str:
* Update box path tests to take new encoding scheme * Formatting * WIP - test against the CI * Revert back test branch * Escape : character * Change wording around encoded box names * Formatting
* Add path tests for GetApplicationBoxes * Change step name to include this application and add list box name tests * Spacing * Reduce number of redundant steps * Add query to boxes path test * Boxes: Point go-algorand to boxes_response_rework (#210) * Revert back go-algorand testing branch Co-authored-by: Michael Diamant <[email protected]>
algochoi
commented
Aug 22, 2022
tzaffi
reviewed
Aug 30, 2022
…ng (#231) * Revert compile sourcemap (#227) * Revert compile sourcemap * Add space * Delete sourcemap2.json * Bugfix: channel v source (#224) * Deprecation of langspec testcases (#225) Co-authored-by: algochoi <[email protected]> Co-authored-by: Zeph Grunschlag <[email protected]>
* Add indexer box path tests * Change API names and add limit query param * Add box name to indexer path test * Edit query param in boxes API * Revert changes to algod * Compile teal app instead of using binary * Add next field to boxes test endpoint * update test case for next token Co-authored-by: Hang Su <[email protected]>
Co-authored-by: Zeph Grunschlag <[email protected]>
ahangsu
reviewed
Sep 6, 2022
ahangsu
reviewed
Sep 14, 2022
* minor on utils/unused_steps * add indexer client to applications.feature * merge step for indexer * add indexer confirmed steps * add indexer confirmed steps * sleep time decide * change to b64 encodings * millisecond nightmare * revert prev b64 * pin commit before merge with feature branch * per Zeph's suggestion on expect steps * unify with applications.boxes * phrasing * update indexer branch and commit, add comments to explain some thinking
tzaffi
reviewed
Sep 19, 2022
tzaffi
reviewed
Sep 20, 2022
tzaffi
approved these changes
Sep 20, 2022
tzaffi
reviewed
Sep 21, 2022
Merge in develop and update support for go-algorand#4689
committing as the boxes branch has been merged and SDK tests are failing Co-authored-by: Hang Su <[email protected]>
tzaffi
reviewed
Oct 31, 2022
dupe of CHANNEL
Co-authored-by: Hang Su <[email protected]>
Co-authored-by: Hang Su <[email protected]>
|
For ease of reference, here's the associated SDK PRs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stores all the diffs/commits to support application Boxes. This branch roughly tracks the
feature/avm-boxbranch ingo-algorand.